Re: [PATCH 4/7] resource: Use typedef for alignf callback

Andy Shevchenko
2023-12-22T13:30:24Z

On Fri, Dec 22, 2023 at 02:28:58PM +0200, Ilpo Järvinen wrote:
> To make it simpler to declare resource constraint alignf callbacks, add
> typedef for it and document it.

Suggested-by?

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

> +/**
> + * resource_alignf - Resource alignment callback
> + * @data: Private data used by the callback
> + * @res: Resource candidate range (an empty resource slot)
> + * @size: The minimum size of the empty slot
> + * @align: Alignment from the constraints
> + *
> + * Callback allows calculating resource placement and alignment beyond min,
> + * max, and align fields in the struct resource_constraint.
> + *
> + * Return: Start address for the resource.
> + */
> +typedef resource_size_t (*resource_alignf)(void *data,
> + const struct resource *res,
> + resource_size_t size,
> + resource_size_t align);

Never saw typedef kernel-doc before, so hopefully this will be rendered
just fine.

--
With Best Regards,
Andy Shevchenko