Re: [PATCH 5/7] resource: Handle simple alignment inside __find_empty_resource_slot()

Andy Shevchenko
2023-12-22T13:34:35Z

On Fri, Dec 22, 2023 at 02:28:59PM +0200, Ilpo Järvinen wrote:
> allocate_resource() accepts alignf callback to perform custom alignment

s/alignf callback/->alignf() callback/

?

> beyond constraint->align. If alignf is NULL, simple_align_resource() is
> used which only returns avail->start (no change).
>
> Using avail->start directly is natural and can be done with a
> conditional in __find_empty_resource_slot() instead which avoids
> unnecessarily using callback. It makes the code inside
> __find_empty_resource_slot() more obvious and removes the need for the
> caller to provide constraint->alignf unnecessarily.
>
> This is preparation for exporting find_empty_resource_slot().

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

...

> if (avail.start >= tmp.start) {
> alloc.flags = avail.flags;
> - alloc.start = constraint->alignf(constraint->alignf_data, &avail,
> - size, constraint->align);
> + if (alignf) {
> + alloc.start = alignf(constraint->alignf_data,

> + &avail, size,
> + constraint->align);

Maybe one line? It used to be a longer line in the old code.

> + } else {
> + alloc.start = avail.start;
> + }

--
With Best Regards,
Andy Shevchenko