From: Frank Li <Frank.li@nxp.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: bhelgaas@google.com, conor+dt@kernel.org,
devicetree@vger.kernel.org, festevam@gmail.com,
helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev,
kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org,
kw@linux.com, l.stach@pengutronix.de,
linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org,
robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v6 15/16] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string
Date: Tue, 26 Dec 2023 16:53:01 -0500 [thread overview]
Message-ID: <ZYtLPQgMVUSNduLG@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <0233cf48-93cb-4f19-ad1d-e3e1835c1fef@linaro.org>
On Tue, Dec 26, 2023 at 08:01:53PM +0100, Krzysztof Kozlowski wrote:
> On 26/12/2023 17:12, Frank Li wrote:
> > On Mon, Dec 25, 2023 at 08:16:17PM +0100, Krzysztof Kozlowski wrote:
> >> On 24/12/2023 19:32, Frank Li wrote:
> >>> Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string.
> >>> Add reg-name: "atu", "dbi2", "dma" and "app".
> >>> Reuse PCI linux,pci-domain as controller id at endpoint.
> >>>
> >>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> >>> ---
> >>>
> >>
> >> ...
> >>
> >>> +# reuse PCI linux,pci-domain as controller id at Endpoint
> >>> + - if:
> >>> + properties:
> >>> + compatible:
> >>> + enum:
> >>> + - fsl,imx95-pcie-ep
> >>> + then:
> >>> + properties:
> >>> + linux,pci-domain: true
> >>
> >> Same comment: why do you need? Don't ignore my feedback. You responded
> >> you will fix it, but it is still here...
> >
> > DTB_CHECK report error after I remove it. linux,pci-domain is only define
> > in pci, not pci-ep.
>
> Ah, thank you, indeed.
>
> >
> > So I add comments about this. linux,pci-domain was resued ad controller id.
>
> However maybe there is reason why it is not for endpoints. The
> description is saying it is valid only for host bridge, so maybe it
> should not be used for endpoint case?
EP side, it is not PCI bus. So it is reasonable that linux,pci-doamin not
in EP side.
iMX6 host driver(and other some host controller drivers) already use it as
"controller id". EP driver is mostly reused with host bridge drivers. I
think needn't create new property such as "controller_id" for EP only.
A comments should be enough for this case.
Frank
> >
> > If include pci.yaml, there are too much other properties was involved, but
> > not used by pci-ep.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-12-26 21:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 18:32 [PATCH v6 00/16] PCI: imx6: Clean up and add imx95 pci support Frank Li
2023-12-24 18:32 ` [PATCH v6 01/16] PCI: imx6: Simplify clock handling by using bulk_clk_*() function Frank Li
2023-12-24 18:32 ` [PATCH v6 02/16] PCI: imx6: Simplify phy handling by using by using IMX6_PCIE_FLAG_HAS_PHY Frank Li
2023-12-24 18:32 ` [PATCH v6 03/16] PCI: imx6: Simplify reset handling by using by using *_FLAG_HAS_*_RESET Frank Li
2023-12-24 18:32 ` [PATCH v6 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Frank Li
2023-12-24 18:32 ` [PATCH v6 05/16] PCI: imx6: Using "linux,pci-domain" as slot ID Frank Li
2023-12-24 18:32 ` [PATCH v6 06/16] PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask Frank Li
2023-12-24 18:32 ` [PATCH v6 07/16] PCI: imx6: Simplify configure_type() by using mode_off and mode_mask Frank Li
2023-12-24 18:32 ` [PATCH v6 08/16] PCI: imx6: Simplify switch-case logic by involve init_phy callback Frank Li
2023-12-24 18:32 ` [PATCH v6 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check Frank Li
2023-12-25 19:05 ` Krzysztof Kozlowski
2023-12-25 19:09 ` Krzysztof Kozlowski
2023-12-24 18:32 ` [PATCH v6 10/16] dt-bindings: imx6q-pcie: restruct reg and reg-name Frank Li
2023-12-25 19:11 ` Krzysztof Kozlowski
2023-12-24 18:32 ` [PATCH v6 11/16] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string Frank Li
2023-12-25 19:13 ` Krzysztof Kozlowski
2023-12-24 18:32 ` [PATCH v6 12/16] PCI: imx6: Add iMX95 PCIe support Frank Li
2023-12-24 18:32 ` [PATCH v6 13/16] PCI: imx6: Clean up get addr_space code Frank Li
2023-12-24 18:32 ` [PATCH v6 14/16] PCI: imx6: Add epc_features in imx6_pcie_drvdata Frank Li
2023-12-24 18:32 ` [PATCH v6 15/16] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string Frank Li
2023-12-25 19:16 ` Krzysztof Kozlowski
2023-12-26 16:12 ` Frank Li
2023-12-26 19:01 ` Krzysztof Kozlowski
2023-12-26 21:53 ` Frank Li [this message]
2023-12-27 12:00 ` Krzysztof Kozlowski
2023-12-24 18:32 ` [PATCH v6 16/16] PCI: imx6: Add iMX95 Endpoint (EP) function support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZYtLPQgMVUSNduLG@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox