From: Niklas Cassel <cassel@kernel.org>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Damien Le Moal" <dlemoal@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] misc: pci_endpoint_test: Use memcpy_toio()/memcpy_fromio() for BAR tests
Date: Wed, 20 Mar 2024 09:08:25 +0100 [thread overview]
Message-ID: <ZfqZeQ_Spx0FzH6o@ryzen> (raw)
In-Reply-To: <49cb292a-fc84-4f5f-a1cd-8650341c4517@linux.intel.com>
On Tue, Mar 19, 2024 at 03:39:09PM -0700, Kuppuswamy Sathyanarayanan wrote:
> > +
> > + read_buf = kmalloc(buf_size, GFP_KERNEL);
> > + if (!read_buf)
> > + return false;
>
> Not freeing the read_buf/write_buf in return path?
That is quite embarrassing...
Thank you Kuppuswamy!
Kind regards,
Niklas
prev parent reply other threads:[~2024-03-20 8:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 21:38 [PATCH v2] misc: pci_endpoint_test: Use memcpy_toio()/memcpy_fromio() for BAR tests Niklas Cassel
2024-03-19 22:39 ` Kuppuswamy Sathyanarayanan
2024-03-20 8:08 ` Niklas Cassel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfqZeQ_Spx0FzH6o@ryzen \
--to=cassel@kernel.org \
--cc=arnd@arndb.de \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox