From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E229C657C4 for ; Mon, 8 Apr 2024 11:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712576231; cv=none; b=CLcAKFtcbR9RvRbaXynnXNLnYT/qKXhqyZz2/24HEyt3qHyEMlhpTF/QPJZMIauMxH0Siwghwfe5LkMHVCCRtXD8NCjrH3BJ5RjeUrZW3RMdStiXdbANgeXlNzWNy+gUmbEss8ppCVqtAR44apWukWfgS+Q/bRfA1ZwXgrHYC8A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712576231; c=relaxed/simple; bh=iINuaUKCNq7mtaWLIm7uKIvUKcwCT/vZrWolmbXHP8o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Kkti5Cr344tEOmzEMmltcBqYvqAVn5jGweUDoJYPhrEWOOirhv2TKEEF2t3oD1dNcg0GfsznEve0sxwKdiYcYSXdEFek5yMTXzS/0Sv/ab/I5hTos4xyi91/9DHwcdMH7HP//2kUX/8H/YxWLISlBGUAjzchI3PWUIgXRjuBefU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=QP3T5Xdu; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="QP3T5Xdu" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-516ab4b3251so4673233e87.0 for ; Mon, 08 Apr 2024 04:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1712576227; x=1713181027; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=iINuaUKCNq7mtaWLIm7uKIvUKcwCT/vZrWolmbXHP8o=; b=QP3T5XduYVfIUt7CyoSE6SnZ2IUEmPPf3B5zk/ya0tVLv6D0x1kC1d7ncTMFQAKXnY z8Wfevfjdw0uLCix3qwZEEYziAbLQAFe+9GDCl/YohiR0f+wbYpCnPaULh2VeAhatiFv XoNqOZl2iUp1WmSmZ7/L59nJIBbGNCFm/LIfZkw1K3dI5gCfHuclYO47yTH/8mfYNbfy ptmdZzoBz1vbgAEgxh82m0vE8/yta6luyPVy+t7G/DpLSlCvsGG+Olyb/0dIYQJFGALV mljf4Uu8Sn1VsGqMOctHtSTNr99EZkEi+UiZtQk0taDn89DXew0+0/xSEsZUfqNMuOzC ORNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712576227; x=1713181027; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iINuaUKCNq7mtaWLIm7uKIvUKcwCT/vZrWolmbXHP8o=; b=GE/S0Em1GeoFatPGApcS0pGrCwnQhnDJpWUQDGkZeE2U0OhrnX7MTzW+TThxN5/3e1 m5hdG3YCscktzKd7DDpfQx8Rtth0baTtIinBYtA4OdJDj5lJJovri5a5STBVFYmgxqXN iL2zkwXpBzm46QqBWHuSZrDtBUHmT8pYYOXnrzulf+lYaRnAOCcUSiVxTezp720Ab/Md YRrbtiSTqw9DsifA5mcaGHx5tTYngGPTS0eepsZ5mNUDKY6RjsR2LSd6kLCNx8IYtxvV MjXv5ktxlSPcZY5W71BKL55pdmenkHG62gu3X9cuNJTFt0sd+Xe1erabdrgysCBM4eWJ AkFQ== X-Forwarded-Encrypted: i=1; AJvYcCV/GtUCOpLr1UU8czHFoutE/VuaGg+yIU7ISJt9SjcOenfi+uc6VVi7sjdqVvkTm0vumkEn4y3seawU62LXNqcNLQDnKZE5+SA/ X-Gm-Message-State: AOJu0YyYDkNYnveVbuZd80JWUVdX/lFVYFV1esR0+IkpzSkJmpT/Jqxm n5NFBf/gvXnF/24A4pPNwOb73nkHS7MpBLFsAq/3CYkjbRya9jTS9yXrZe+LC1o= X-Google-Smtp-Source: AGHT+IEAArslfEzp+o/yxGarOJlYV2s6GBcovR6lg5JpRDG0E3O4JmQUaqXsZC+GRIs6S/0fe5t6mA== X-Received: by 2002:ac2:5df9:0:b0:515:d50f:c6cc with SMTP id z25-20020ac25df9000000b00515d50fc6ccmr5790286lfq.63.1712576226611; Mon, 08 Apr 2024 04:37:06 -0700 (PDT) Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id fl14-20020a05600c0b8e00b004166d303d6fsm3718576wmb.25.2024.04.08.04.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 04:37:06 -0700 (PDT) Date: Mon, 8 Apr 2024 13:37:01 +0200 From: Jiri Pirko To: Paolo Abeni Cc: Alexander Duyck , Jakub Kicinski , John Fastabend , netdev@vger.kernel.org, bhelgaas@google.com, linux-pci@vger.kernel.org, Alexander Duyck , davem@davemloft.net Subject: Re: [net-next PATCH 00/15] eth: fbnic: Add network driver for Meta Platforms Host Network Interface Message-ID: References: <171217454226.1598374.8971335637623132496.stgit@ahduyck-xeon-server.home.arpa> <20240404132548.3229f6c8@kernel.org> <660f22c56a0a2_442282088b@john.notmuch> <20240404165000.47ce17e6@kernel.org> <678f49b06a06d4f6b5d8ee37ad1f4de804c7751d.camel@redhat.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <678f49b06a06d4f6b5d8ee37ad1f4de804c7751d.camel@redhat.com> Fri, Apr 05, 2024 at 09:11:19AM CEST, pabeni@redhat.com wrote: >On Thu, 2024-04-04 at 17:11 -0700, Alexander Duyck wrote: >> Again, I would say we look at the blast radius. That is how we should >> be measuring any change. At this point the driver is self contained >> into /drivers/net/ethernet/meta/fbnic/. It isn't exporting anything >> outside that directory, and it can be switched off via Kconfig. > >I personally think this is the most relevant point. This is just a new >NIC driver, completely self-encapsulated. I quickly glanced over the What do you mean by "self contained/encapsulated"? You are not using any API outside the driver? Every driver API change that this NIC is going to use is a burden. I did my share of changes like that in the past so I have pretty good notion how painful it often is. >code and it looks like it's not doing anything obviously bad. It really >looks like an usual, legit, NIC driver. > >I don't think the fact that the NIC itself is hard to grasp for anyone Distinguish "hard"/"impossible". >outside makes a difference. Long time ago Greg noted >that drivers has been merged for H/W known to have a _single_ existing >instance (IIRC, I can't find the reference on top of my head, but back >then was quite popular, I hope some other old guy could remember). > >To me, the maintainership burden is on Meta: Alex/Meta will have to >handle bug report, breakages, user-complains (I guess this last would >be the easier part ;). If he/they will not cope with the process we can >simply revert the driver. I would be quite surprised if such situation >should happen, but the impact from my PoV looks minimal. > >TL;DR: I don't see any good reason to not accept this - unless my quick >glance was too quick and very wrong, but it looks like other has >similar view. Do you actually see any good reason to accept this? I mean, really, could you spell out at least one benefit it brings for non-Meta user? I see only gains for Meta and losses for the community.