Re: [PATCH 1/3] PCI: dwc: ep: Add dw_pcie_ep_deinit_notify()

Bjorn Helgaas
2024-05-29T17:25:17Z

On Wed, May 29, 2024 at 04:54:57PM +0200, Niklas Cassel wrote:
> ...

> We should probably also address Bjorn comment:
> "ls and qcom even use *both*: pci_epc_linkdown() but dw_pcie_ep_linkup()."
>
> As far as I can tell, it is only ls (not sure why Bjorn also mentioned qcom):
> drivers/pci/controller/dwc/pci-layerscape-ep.c: pci_epc_linkdown(pci->ep.epc);
> But this should probably also be fixed to use dw_pcie_ep_linkdown().

qcom_pcie_ep_global_irq_thread() calls both pci_epc_linkdown() and