Re: [PATCH 4/9] block: mtip32xx: Replace deprecated PCI functions

Philipp Stanner
2024-08-20T07:29:59Z

On Mon, 2024-08-19 at 21:04 +0300, Andy Shevchenko wrote:
> On Mon, Aug 19, 2024 at 06:51:44PM +0200, Philipp Stanner wrote:
> > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by
> > the
> > PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> > pcim_iomap_table(), pcim_iomap_regions_request_all()").
> >
> > In mtip32xx, these functions can easily be replaced by their
> > respective
> > successors, pcim_request_region() and pcim_iomap(). Moreover, the
> > driver's call to pcim_iounmap_regions() is not necessary, because
> > it's
> > invoked in the remove() function. Cleanup can, hence, be performed
> > by
> > PCI devres automatically.
> >
> > Replace pcim_iomap_regions() and pcim_iomap_table().
> >
> > Remove the call to pcim_iounmap_regions().
>
> ...
>
> int mtip_pci_probe()
>
> >  setmask_err:
> > - pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
> > + pcim_release_region(pdev, MTIP_ABAR);
>
> But why?

EMOREINFOREQUIRED
Why I replace it or why I don't remove it completely?

>
> ...
>
> mtip_pci_remove()
>
> >   pci_disable_msi(pdev);
> >
> > - pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
>
> This is okay.

Removing it is okay, you mean.

>
> ...
>
> >   pci_set_drvdata(pdev, NULL);
>
> Side note: This is done by driver core for the last 10+ years…

Ah you know Andy, kernel programmers be like: "When you're hunting you
better make sure the wild sow is really dead before you load it in your
trunk" ;p

P.

>