Re: [PATCH 8/9] vdap: solidrun: Replace deprecated PCI functions

Andy Shevchenko
2024-08-19T18:37:13Z

On Mon, Aug 19, 2024 at 09:32:00PM +0300, Andy Shevchenko wrote:
> On Mon, Aug 19, 2024 at 06:51:48PM +0200, Philipp Stanner wrote:

...

> > for (i = 0; i < PCI_STD_NUM_BARS; i++) {
> > + if (pci_resource_len(pdev, i)) {

Btw, looking at this you may invert the conditional

for (i = 0; i < PCI_STD_NUM_BARS; i++) {
if (!pci_resource_len(pdev, i))
continue;

It might make patch neater.

> > + psnet->bars[i] = pcim_iomap_region(pdev, i, name);
> > + if (IS_ERR(psnet->bars[i])) {
> > + SNET_ERR(pdev, "Failed to request and map PCI BARs\n");
> > + return PTR_ERR(psnet->bars[i]);
> > + }
> > + }

> >
>
> Blank line leftover.
>
> > }

--
With Best Regards,
Andy Shevchenko