Re: [PATCH 4/9] block: mtip32xx: Replace deprecated PCI functions

Andy Shevchenko
2024-08-19T18:04:55Z

On Mon, Aug 19, 2024 at 06:51:44PM +0200, Philipp Stanner wrote:
> pcim_iomap_regions() and pcim_iomap_table() have been deprecated by the
> PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> pcim_iomap_table(), pcim_iomap_regions_request_all()").
>
> In mtip32xx, these functions can easily be replaced by their respective
> successors, pcim_request_region() and pcim_iomap(). Moreover, the
> driver's call to pcim_iounmap_regions() is not necessary, because it's
> invoked in the remove() function. Cleanup can, hence, be performed by
> PCI devres automatically.
>
> Replace pcim_iomap_regions() and pcim_iomap_table().
>
> Remove the call to pcim_iounmap_regions().

...

int mtip_pci_probe()

> setmask_err:
> - pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);
> + pcim_release_region(pdev, MTIP_ABAR);

But why?

...

mtip_pci_remove()

> pci_disable_msi(pdev);
>
> - pcim_iounmap_regions(pdev, 1 << MTIP_ABAR);

This is okay.

...

> pci_set_drvdata(pdev, NULL);

Side note: This is done by driver core for the last 10+ years…

--
With Best Regards,
Andy Shevchenko