Re: [PATCH] dt-bindings: PCI: qcom: Allow 'vddpe-3v3-supply' again

Dmitry Baryshkov
2024-07-24T17:22:58Z

On Tue, Jul 23, 2024 at 05:13:28PM GMT, Johan Hovold wrote:
> Commit 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to
> dedicated schema") incorrectly removed 'vddpe-3v3-supply' from the
> bindings, which results in DT checker warnings like:
>
> arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb: pcie@600000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected)
> from schema $id: http://devicetree.org/schemas/pci/qcom,pcie.yaml#
>
> Note that this property has been part of the Qualcomm PCIe bindings
> since 2018 and would need to be deprecated rather than simply removed if
> there is a desire to replace it with 'vpcie3v3' which is used for some
> non-Qualcomm controllers.

I think Rob Herring suggested [1] adding the property to the root port
node rather than the host. If that suggestion still applies it might be
better to enable the deprecated propertly only for the hosts, which
already used it, and to define a new property at the root port.

[1] https://lore.kernel.org/lkml/20240604235806.GA1903493-robh@kernel.org/

>
> Fixes: 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
> Documentation/devicetree/bindings/pci/qcom,pcie-common.yaml | 3 +++
> Documentation/devicetree/bindings/pci/qcom,pcie-sc7280.yaml | 3 ---
> Documentation/devicetree/bindings/pci/qcom,pcie-sc8280xp.yaml | 3 ---
> Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 3 +++
> 4 files changed, 6 insertions(+), 6 deletions(-)

--
With best wishes
Dmitry