From: Niklas Cassel <cassel@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Jingoo Han" <jingoohan1@gmail.com>,
linux-pci@vger.kernel.org,
"Rick Wertenbroek" <rick.wertenbroek@gmail.com>
Subject: Re: [PATCH v5 4/6] PCI: endpoint: Update documentation
Date: Fri, 11 Oct 2024 14:20:03 +0200 [thread overview]
Message-ID: <ZwkX81jTn2Ey-avM@ryzen.lan> (raw)
In-Reply-To: <20241011120115.89756-5-dlemoal@kernel.org>
On Fri, Oct 11, 2024 at 09:01:13PM +0900, Damien Le Moal wrote:
> Document the new functions pci_epc_mem_map() and pci_epc_mem_unmap().
> Also add the documentation for the functions pci_epc_map_addr() and
> pci_epc_unmap_addr() that were missing.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> Documentation/PCI/endpoint/pci-endpoint.rst | 29 +++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/Documentation/PCI/endpoint/pci-endpoint.rst b/Documentation/PCI/endpoint/pci-endpoint.rst
> index 21507e3cc238..35f82f2d45f5 100644
> --- a/Documentation/PCI/endpoint/pci-endpoint.rst
> +++ b/Documentation/PCI/endpoint/pci-endpoint.rst
> @@ -117,6 +117,35 @@ by the PCI endpoint function driver.
> The PCI endpoint function driver should use pci_epc_mem_free_addr() to
> free the memory space allocated using pci_epc_mem_alloc_addr().
>
> +* pci_epc_map_addr()
> +
> + A PCI endpoint function driver should use pci_epc_map_addr() to map to a RC
> + PCI address the CPU address of local memory obtained with
> + pci_epc_mem_alloc_addr().
> +
> +* pci_epc_unmap_addr()
> +
> + A PCI endpoint function driver should use pci_epc_unmap_addr() to unmap the
> + CPU address of local memory mapped to a RC address with pci_epc_map_addr().
> +
> +* pci_epc_mem_map()
> +
> + A PCI endpoint controller may impose constraints on the RC PCI addresses that
> + can be mapped. The function pci_epc_mem_map() allows endpoint function
> + drivers to allocate and map controller memory while handling such
> + constraints. This function will determine the size of the memory that must be
> + allocated with pci_epc_mem_alloc_addr() for successfully mapping a RC PCI
> + address range. This function will also indicate the size of the PCI address
> + range that was actually mapped, which can be less than the requested size, as
> + well as the offset into the allocated memory to use for accessing the mapped
> + RC PCI address range.
> +
> +* pci_epc_mem_unmap()
> +
> + A PCI endpoint function driver can use pci_epc_mem_unmap() to unmap and free
> + controller memory that was allocated and mapped using pci_epc_mem_map().
> +
> +
> Other EPC APIs
> ~~~~~~~~~~~~~~
>
> --
> 2.47.0
>
Reviewed-by: Niklas Cassel <cassel@kernel.org>
next prev parent reply other threads:[~2024-10-11 12:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 12:01 [PATCH v5 0/6] Improve PCI memory mapping API Damien Le Moal
2024-10-11 12:01 ` [PATCH v5 1/6] PCI: endpoint: Introduce pci_epc_function_is_valid() Damien Le Moal
2024-10-11 12:01 ` [PATCH v5 2/6] PCI: endpoint: Improve pci_epc_mem_alloc_addr() Damien Le Moal
2024-10-11 12:01 ` [PATCH v5 3/6] PCI: endpoint: Introduce pci_epc_mem_map()/unmap() Damien Le Moal
2024-10-11 12:07 ` Niklas Cassel
2024-10-11 12:21 ` Damien Le Moal
2024-10-12 9:42 ` Manivannan Sadhasivam
2024-10-11 12:22 ` Niklas Cassel
2024-10-11 12:01 ` [PATCH v5 4/6] PCI: endpoint: Update documentation Damien Le Moal
2024-10-11 12:20 ` Niklas Cassel [this message]
2024-10-11 12:01 ` [PATCH v5 5/6] PCI: endpoint: test: Use pci_epc_mem_map/unmap() Damien Le Moal
2024-10-11 12:01 ` [PATCH v5 6/6] PCI: dwc: endpoint: Implement the pci_epc_ops::get_mem_map() operation Damien Le Moal
2024-10-11 12:19 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwkX81jTn2Ey-avM@ryzen.lan \
--to=cassel@kernel.org \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=dlemoal@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=rick.wertenbroek@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox