From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41481C6FA82 for ; Fri, 23 Sep 2022 12:42:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229507AbiIWMmH (ORCPT ); Fri, 23 Sep 2022 08:42:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231221AbiIWMmF (ORCPT ); Fri, 23 Sep 2022 08:42:05 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88A71132FF1; Fri, 23 Sep 2022 05:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663936923; x=1695472923; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=clNq8dpfrkH+SH9w6jXyZ7MWDXW18Peooue3eo5KpHE=; b=Ab70J8IVb/lJBswTapg3vuIizgdN8mgkuM3UODM41z6nUES7Z9j3djd8 c7Mq9lTf8iR6jmiCHxDhoEZpYI/Wt+ARscU1RRxUmox9BwVGxqf2Gfm3F C2gXvS7HUDdNniHJuEOkXym3WwfqlD2m/aD/DwGIy9tnq2VCpXV+tJ283 /RSP1KRzWVoZ6Dgj3WWiE8Kl71OmMzMqKKNZVMrdnuge88frJxFMYORVf xrWglKDgMkA4OQdOJbz4Udcew8Afc4jYNAfo33ISPI73tnL5h0usUW8h9 ifqOY7MN9CmFDQOIXOeNx8/SkaoP8U47E14z2fkcTCifgKkkdVnUYUGH8 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10479"; a="362394485" X-IronPort-AV: E=Sophos;i="5.93,339,1654585200"; d="scan'208";a="362394485" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 05:42:03 -0700 X-IronPort-AV: E=Sophos;i="5.93,339,1654585200"; d="scan'208";a="653387301" Received: from blu2-mobl3.ccr.corp.intel.com (HELO [10.254.214.140]) ([10.254.214.140]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 05:41:58 -0700 Message-ID: Date: Fri, 23 Sep 2022 20:41:56 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Christoph Hellwig , Bjorn Helgaas , Kevin Tian , Ashok Raj , Will Deacon , Robin Murphy , Jean-Philippe Brucker , Dave Jiang , Fenghua Yu , Vinod Koul , Eric Auger , Liu Yi L , Jacob jun Pan , Zhangfei Gao , Zhu Tony , iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v13 07/13] iommu/vt-d: Add SVA domain support Content-Language: en-US To: Jason Gunthorpe References: <20220906124458.46461-1-baolu.lu@linux.intel.com> <20220906124458.46461-8-baolu.lu@linux.intel.com> <075278e0-77ce-2361-8ded-6cd6bb20216f@linux.intel.com> From: Baolu Lu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On 2022/9/23 20:15, Jason Gunthorpe wrote: > On Fri, Sep 23, 2022 at 10:21:51AM +0800, Baolu Lu wrote: > >> At the beginning of this project, I wanted to consolidate the mm >> notifications into the core. However, ARM SMMUv3 and Intel handle the mm >> notifications a little differently. Then I decided to do this work >> separately from the current series. > > It doesn't look really different.. They are essentially the same, but slightly different. For example, arm smmuv3 provides .free_notifier, and I don't think it could be merged to the release callback. > > The SVA iommu domain needs two new ops triggered by the notifier: > > - 'stop using the mm, subsitute a blocking domain' tied to release > - Cache invalidate a range, maybe this is just iotlb_sync_map() > > And we could even think about the first as the core code literally > attaching a dummy blocking domain and releasing the SVA domain. There > is no reason we need to have every driver do this tricky bit of > lifecycle management. Yes. I have similar ideas. We can further discuss it with the real code later. Best regards, baolu