From: Edward Cree <ecree@solarflare.com>
To: Bjorn Helgaas <helgaas@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Cc: <kbuild-all@lists.01.org>, <linux-renesas-soc@vger.kernel.org>,
"Luc Van Oostenryck" <luc.vanoostenryck@gmail.com>,
<linux-pci@vger.kernel.org>
Subject: Re: [renesas-drivers:master 69/80] drivers/net/ethernet/sfc/efx_common.c:1232:19: sparse: sparse: incompatible types for operation (==):
Date: Wed, 15 Jul 2020 09:47:43 +0100 [thread overview]
Message-ID: <a18d4e1e-2ecb-21dc-2547-fa7529e76edd@solarflare.com> (raw)
In-Reply-To: <20200714185622.GA408711@bjorn-Precision-5520>
On 14/07/2020 19:56, Bjorn Helgaas wrote:
> [+cc Luc, linux-pci]
>
> I think what's necessary here is to replace "enum pci_channel_state
> state" with "pci_channel_state_t state", as in 16d79cd4e23b ("PCI: Use
> 'pci_channel_state_t' instead of 'enum pci_channel_state'"):
>
> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?id=16d79cd4e23b
>
> This change should be safe even without 16d79cd4e23b, so there won't
> be a revlock if you make it in the renesas-drivers tree.
This is presumably goingto happen in any tree that pulls both net-next
and pci/next. So shouldn't we make the change in net-next, rather than
in a renesas tree that really has little to do with it other than being
the first place the problem showed up?
Apart from that question, the fix you describe sounds reasonable afaict,
and I'll happily Ack a patch.
-ed
next prev parent reply other threads:[~2020-07-15 8:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202007150206.kfukZxuy%lkp@intel.com>
2020-07-14 18:56 ` [renesas-drivers:master 69/80] drivers/net/ethernet/sfc/efx_common.c:1232:19: sparse: sparse: incompatible types for operation (==): Bjorn Helgaas
2020-07-15 8:47 ` Edward Cree [this message]
2020-07-15 8:55 ` Geert Uytterhoeven
2020-07-15 9:04 ` Edward Cree
2020-07-15 10:21 ` Luc Van Oostenryck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a18d4e1e-2ecb-21dc-2547-fa7529e76edd@solarflare.com \
--to=ecree@solarflare.com \
--cc=geert+renesas@glider.be \
--cc=helgaas@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=luc.vanoostenryck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox