From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A15C47247 for ; Tue, 5 May 2020 13:25:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11CBF20836 for ; Tue, 5 May 2020 13:25:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729091AbgEENZN (ORCPT ); Tue, 5 May 2020 09:25:13 -0400 Received: from mx2.suse.de ([195.135.220.15]:46738 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728934AbgEENZN (ORCPT ); Tue, 5 May 2020 09:25:13 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 55C02AB89; Tue, 5 May 2020 13:25:13 +0000 (UTC) Message-ID: Subject: Re: [PATCH v2 2/4] PCI: brcmstb: Fix window register offset from 4 to 8 From: Nicolas Saenz Julienne To: Jim Quinlan Cc: Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Florian Fainelli , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Jeremy Linton , Andrew Murray , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:PCI NATIVE HOST BRIDGE AND ENDPOINT DRIVERS" , open list Date: Tue, 05 May 2020 15:25:07 +0200 In-Reply-To: <20200501142831.35174-3-james.quinlan@broadcom.com> References: <20200501142831.35174-1-james.quinlan@broadcom.com> <20200501142831.35174-3-james.quinlan@broadcom.com> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-WdhCVQQ77luNuTrwjynR" User-Agent: Evolution 3.36.2 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org --=-WdhCVQQ77luNuTrwjynR Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2020-05-01 at 10:28 -0400, Jim Quinlan wrote: > From: Jim Quinlan >=20 > The outbound memory window registers were being referenced > with an incorrect stride offset. This probably wasn't noticed > previously as there was likely only one such window employed. >=20 > Signed-off-by: Jim Quinlan > Acked-by: Florian Fainelli >=20 > Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller > driver") > --- Acked-by: Nicolas Saenz Julienne Regards, Nicolas > drivers/pci/controller/pcie-brcmstb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/pci/controller/pcie-brcmstb.c > b/drivers/pci/controller/pcie-brcmstb.c > index 454917ee9241..5b0dec5971b8 100644 > --- a/drivers/pci/controller/pcie-brcmstb.c > +++ b/drivers/pci/controller/pcie-brcmstb.c > @@ -54,11 +54,11 @@ > =20 > #define PCIE_MISC_CPU_2_PCIE_MEM_WIN0_LO 0x400c > #define PCIE_MEM_WIN0_LO(win) \ > - PCIE_MISC_CPU_2_PCIE_MEM_WIN0_LO + ((win) * 4) > + PCIE_MISC_CPU_2_PCIE_MEM_WIN0_LO + ((win) * 8) > =20 > #define PCIE_MISC_CPU_2_PCIE_MEM_WIN0_HI 0x4010 > #define PCIE_MEM_WIN0_HI(win) \ > - PCIE_MISC_CPU_2_PCIE_MEM_WIN0_HI + ((win) * 4) > + PCIE_MISC_CPU_2_PCIE_MEM_WIN0_HI + ((win) * 8) > =20 > #define PCIE_MISC_RC_BAR1_CONFIG_LO 0x402c > #define PCIE_MISC_RC_BAR1_CONFIG_LO_SIZE_MASK 0x1f --=-WdhCVQQ77luNuTrwjynR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl6xaTMACgkQlfZmHno8 x/7l/wgAqNRIM6mZcLbEIafYCYznZMUminRZvoGWDMa0AwR/Ei3ngd3/mhph4nuA lsn6NfNF2SbIpz7gE+UslD9UW6L8MWG9M0cAfMKPyJQuqkGjYa/0cTBJIr+VVTfc fsbKn/xCa5Dku8sbKXAvjxMh3hzgFrZrYIlnJwdLPvD4oxUHkDoXLJyowalp4scx MELFQgm2NyYvznpYRhKwnbIYZNqQis9RpZgimsrLpjOTXYFeARKZAY+p63cn4c8u kiANyMwcDyNARBa4B5cjg7gxT20kwIQDMPGj63lp8wknIuIkwf9mKuhiglcrjlHF bNmX73xmfHGy7qSbCisqETc6qyxKsA== =PUO0 -----END PGP SIGNATURE----- --=-WdhCVQQ77luNuTrwjynR--