Re: [PATCH] PCI: Increase resource array mask bit size in pcim_iomap_regions()

["Rolf Eike Beer" <eike-kernel@sf-tec.de>]

> DEVICE_COUNT_RESOURCE will be bigger than 16 when SRIOV supported is
> enabled.
>
> Let them pass with int just like pci_enable_resources().
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
>  include/linux/pci.h |    6 +++---
>  lib/devres.c        |    6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> Index: linux-2.6/include/linux/pci.h
> ===================================================================
> --- linux-2.6.orig/include/linux/pci.h
> +++ linux-2.6/include/linux/pci.h
> @@ -1433,10 +1433,10 @@ static inline void pci_fixup_device(enum
>  void __iomem *pcim_iomap(struct pci_dev *pdev, int bar, unsigned long
> maxlen);
>  void pcim_iounmap(struct pci_dev *pdev, void __iomem *addr);
>  void __iomem * const *pcim_iomap_table(struct pci_dev *pdev);
> -int pcim_iomap_regions(struct pci_dev *pdev, u16 mask, const char *name);
> -int pcim_iomap_regions_request_all(struct pci_dev *pdev, u16 mask,
> +int pcim_iomap_regions(struct pci_dev *pdev, int mask, const char *name);
> +int pcim_iomap_regions_request_all(struct pci_dev *pdev, int mask,
>  				   const char *name);
[...]

You are switching from unsigned to signed here, is this intentional? In my
feeling such masks should end up in an unsigned int, no?

Eike