From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=arndb.de header.i=@arndb.de header.b="M8oHNdH+"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="gvF3JFrw" Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3727BBD; Fri, 1 Dec 2023 06:55:49 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 6FA835808AE; Fri, 1 Dec 2023 09:43:57 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 01 Dec 2023 09:43:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1701441837; x=1701449037; bh=kK o4dJKblO+HlaEynT7R0ipo9rNcBzF1TALtacSN8BE=; b=M8oHNdH+cvykmc/+5J 8RMXWyg22pwYkaY44RoX9SPAkdK1aLBFwwkj4sptf+YpDIdDWuTHixMt9aEH++tj kRSLFukS+/iWZDl3Q0aoNgsvZ8NUjDBSh39eGILjEePgB5J6m3aLFYpHYIztcwMU jKm81uFGfDBlzWrPt5/0p7DrQTiGlFdjyBx76kxrq+8KsEBvUgXzyCBFFzMl0fNL i8wvSsEhMh2XHOhbJ08aVytYJYkjEYgxtRGwAR+RCpNkU4rOpaDvol39QD0QGJDx U3QPyA+VAYxSUKSbtQrHD//p9vvDd8gZi+BgknFw5FSC0jNXuHmv9Jf9vMz90S3w sPuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1701441837; x=1701449037; bh=kKo4dJKblO+Hl aEynT7R0ipo9rNcBzF1TALtacSN8BE=; b=gvF3JFrwR29gFH3qJWYjCOqt3lyop MwdkBKVOAx3QaD9AsJ+mKQvXRb+g3ZVqwY8+x4NjTbHwwvcebV9LRkL7NEtTJvfE 3oBykOvMihi81cveRMT/4Uk8DBrNnKptFYiNvuF75XpUEv4CgHRDUFgaBehOJkOI HKPkil0zv46wXWPldhcOqaBYlgC4878tbGVMBU3DNpqk0ivMSXm8doZ391JausdQ fFXr8GVgKGWxuyXGeJvSfi52quDYp0TAAIcZb59B9ORY1oxRebTGIctziyUCT8L9 QueLm9VM9VjhHwOyEP8SS6rU/u1TRMV8T3fZ+jj98h2Ed9exim2dstO6g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeiledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 75EBCB6008D; Fri, 1 Dec 2023 09:43:55 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1178-geeaf0069a7-fm-20231114.001-geeaf0069 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: In-Reply-To: <20231201121622.16343-2-pstanner@redhat.com> References: <20231201121622.16343-1-pstanner@redhat.com> <20231201121622.16343-2-pstanner@redhat.com> Date: Fri, 01 Dec 2023 15:43:35 +0100 From: "Arnd Bergmann" To: "Philipp Stanner" , "Bjorn Helgaas" , "Andrew Morton" , "Dan Williams" , "Jonathan Cameron" , "Jakub Kicinski" , "Dave Jiang" , "Uladzislau Koshchanka" , "Neil Brown" , "Niklas Schnelle" , "John Sanpe" , "Kent Overstreet" , "Masami Hiramatsu" , "Kees Cook" , "David Gow" , "Yury Norov" , "wuqiang.matt" , "Jason Baron" , "Kefeng Wang" , "Ben Dooks" , "Danilo Krummrich" Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Linux-Arch Subject: Re: [PATCH v2 1/4] lib: move pci_iomap.c to drivers/pci/ Content-Type: text/plain On Fri, Dec 1, 2023, at 13:16, Philipp Stanner wrote: > > -#ifdef CONFIG_PCI > /** You should not remove the #ifdef here, it probably results in a build failure when CONFIG_GENERIC_PCI_IOMAP is set and GENERIC_PCI is not. Alternatively you could use Kconfig or Makefile logic to prevent the file from being built without CONFIG_PCI. Arnd