From: Markus Elfring <Markus.Elfring@web.de>
To: "Anand Moon" <linux.amoon@gmail.com>,
linux-pci@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI: j721e: Propagate dev_err_probe return value
Date: Sat, 18 Oct 2025 10:56:13 +0200 [thread overview]
Message-ID: <a2cefc72-de44-4a23-92d2-44b58c8c13fe@web.de> (raw)
In-Reply-To: <20251014113234.44418-2-linux.amoon@gmail.com>
> Ensure that the return value from dev_err_probe() is consistently assigned
> back to ret in all error paths within j721e_pcie_probe(). This ensures
> the original error code are propagation for debugging.
I find the change description improvable.
I propose to take another source code transformation approach better into account.
https://elixir.bootlin.com/linux/v6.17.1/source/drivers/base/core.c#L5031-L5075
Example:
https://elixir.bootlin.com/linux/v6.17.1/source/drivers/pci/controller/cadence/pci-j721e.c#L444-L636
ret = dev_err_probe(dev, cdns_pcie_init_phy(dev, cdns_pcie), "Failed to init phy\n");
if (ret)
goto err_get_sync;
How do you think about to achieve such a source code variant also with the help of
the semantic patch language (Coccinelle software)?
Regards,
Markus
next prev parent reply other threads:[~2025-10-18 8:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 11:32 [PATCH v1 0/3] PCI: j721e: A couple of cleanups Anand Moon
2025-10-14 11:32 ` [PATCH v1 1/3] PCI: j721e: Propagate dev_err_probe return value Anand Moon
2025-10-18 8:56 ` Markus Elfring [this message]
2025-10-18 9:22 ` [PATCH " Anand Moon
2025-10-18 10:42 ` Markus Elfring
2025-10-19 10:15 ` Anand Moon
2025-10-19 11:12 ` [1/3] " Markus Elfring
2025-10-19 14:45 ` [PATCH 1/3] " Christophe JAILLET
2025-10-19 17:13 ` [1/3] " Markus Elfring
2025-10-19 17:45 ` Markus Elfring
2025-10-18 11:40 ` Markus Elfring
2025-10-19 16:25 ` Markus Elfring
2025-10-18 9:48 ` [PATCH v1 1/3] " Dan Carpenter
2025-10-19 6:00 ` Anand Moon
2025-10-14 11:32 ` [PATCH v1 2/3] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Anand Moon
2025-10-18 9:33 ` [PATCH " Markus Elfring
2025-10-18 9:49 ` [PATCH v1 " Dan Carpenter
2025-10-18 9:53 ` Dan Carpenter
2025-10-14 11:32 ` [PATCH v1 3/3] PCI: j721e: Use inline reset GPIO assignment and drop local variable Anand Moon
2025-10-18 14:20 ` [PATCH " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2cefc72-de44-4a23-92d2-44b58c8c13fe@web.de \
--to=markus.elfring@web.de \
--cc=bhelgaas@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).