From: Jon Derrick <jonathan.derrick@intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-block@vger.kernel.org, Keith Busch <keith.busch@intel.com>,
stable@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] pci/vmd: Move srcu cleanup after bus/irq domain removal
Date: Thu, 1 Jun 2017 12:30:21 -0600 [thread overview]
Message-ID: <a2ea4fb0-f451-ab6e-05db-1bf0a7a74807@intel.com> (raw)
In-Reply-To: <1497996784-9177-1-git-send-email-jonathan.derrick@intel.com>
+linux-pci
On 06/20/2017 04:13 PM, Jon Derrick wrote:
> Recent __call_srcu changes have exposed that we need to cleanup srcu
> structures after pci_stop_root_bus calls into vmd_msi_free.
>
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> Acked-by: Keith Busch <keith.busch@intel.com>
> Cc: <stable@vger.kernel.org> # 4.11
> ---
> drivers/pci/host/vmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
> index e27ad2a..642a182 100644
> --- a/drivers/pci/host/vmd.c
> +++ b/drivers/pci/host/vmd.c
> @@ -733,10 +733,10 @@ static void vmd_remove(struct pci_dev *dev)
> struct vmd_dev *vmd = pci_get_drvdata(dev);
>
> vmd_detach_resources(vmd);
> - vmd_cleanup_srcu(vmd);
> sysfs_remove_link(&vmd->dev->dev.kobj, "domain");
> pci_stop_root_bus(vmd->bus);
> pci_remove_root_bus(vmd->bus);
> + vmd_cleanup_srcu(vmd);
> vmd_teardown_dma_ops(vmd);
> irq_domain_remove(vmd->irq_domain);
> }
>
next parent reply other threads:[~2017-06-01 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1497996784-9177-1-git-send-email-jonathan.derrick@intel.com>
2017-06-01 18:30 ` Jon Derrick [this message]
2017-06-20 23:29 ` [PATCH] pci/vmd: Move srcu cleanup after bus/irq domain removal Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ea4fb0-f451-ab6e-05db-1bf0a7a74807@intel.com \
--to=jonathan.derrick@intel.com \
--cc=helgaas@kernel.org \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).