* Re: [PATCH] pci/vmd: Move srcu cleanup after bus/irq domain removal
[not found] <1497996784-9177-1-git-send-email-jonathan.derrick@intel.com>
@ 2017-06-01 18:30 ` Jon Derrick
2017-06-20 23:29 ` Keith Busch
0 siblings, 1 reply; 2+ messages in thread
From: Jon Derrick @ 2017-06-01 18:30 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-block, Keith Busch, stable, linux-pci
+linux-pci
On 06/20/2017 04:13 PM, Jon Derrick wrote:
> Recent __call_srcu changes have exposed that we need to cleanup srcu
> structures after pci_stop_root_bus calls into vmd_msi_free.
>
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> Acked-by: Keith Busch <keith.busch@intel.com>
> Cc: <stable@vger.kernel.org> # 4.11
> ---
> drivers/pci/host/vmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
> index e27ad2a..642a182 100644
> --- a/drivers/pci/host/vmd.c
> +++ b/drivers/pci/host/vmd.c
> @@ -733,10 +733,10 @@ static void vmd_remove(struct pci_dev *dev)
> struct vmd_dev *vmd = pci_get_drvdata(dev);
>
> vmd_detach_resources(vmd);
> - vmd_cleanup_srcu(vmd);
> sysfs_remove_link(&vmd->dev->dev.kobj, "domain");
> pci_stop_root_bus(vmd->bus);
> pci_remove_root_bus(vmd->bus);
> + vmd_cleanup_srcu(vmd);
> vmd_teardown_dma_ops(vmd);
> irq_domain_remove(vmd->irq_domain);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pci/vmd: Move srcu cleanup after bus/irq domain removal
2017-06-01 18:30 ` [PATCH] pci/vmd: Move srcu cleanup after bus/irq domain removal Jon Derrick
@ 2017-06-20 23:29 ` Keith Busch
0 siblings, 0 replies; 2+ messages in thread
From: Keith Busch @ 2017-06-20 23:29 UTC (permalink / raw)
To: Jon Derrick; +Cc: Bjorn Helgaas, linux-block, stable, linux-pci
> On 06/20/2017 04:13 PM, Jon Derrick wrote:
> Recent __call_srcu changes have exposed that we need to cleanup srcu
> structures after pci_stop_root_bus calls into vmd_msi_free.
Adding the obligatory:
Fixes: 3906b91844d6 ("PCI: vmd: Use SRCU as a local RCU to prevent delaying global RCU")
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> Acked-by: Keith Busch <keith.busch@intel.com>
> Cc: <stable@vger.kernel.org> # 4.11
> ---
> drivers/pci/host/vmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c
> index e27ad2a..642a182 100644
> --- a/drivers/pci/host/vmd.c
> +++ b/drivers/pci/host/vmd.c
> @@ -733,10 +733,10 @@ static void vmd_remove(struct pci_dev *dev)
> struct vmd_dev *vmd = pci_get_drvdata(dev);
>
> vmd_detach_resources(vmd);
> - vmd_cleanup_srcu(vmd);
> sysfs_remove_link(&vmd->dev->dev.kobj, "domain");
> pci_stop_root_bus(vmd->bus);
> pci_remove_root_bus(vmd->bus);
> + vmd_cleanup_srcu(vmd);
> vmd_teardown_dma_ops(vmd);
> irq_domain_remove(vmd->irq_domain);
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-06-20 23:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1497996784-9177-1-git-send-email-jonathan.derrick@intel.com>
2017-06-01 18:30 ` [PATCH] pci/vmd: Move srcu cleanup after bus/irq domain removal Jon Derrick
2017-06-20 23:29 ` Keith Busch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).