From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH] pci/vmd: Move srcu cleanup after bus/irq domain removal To: Bjorn Helgaas Cc: linux-block@vger.kernel.org, Keith Busch , stable@vger.kernel.org, linux-pci@vger.kernel.org References: <1497996784-9177-1-git-send-email-jonathan.derrick@intel.com> From: Jon Derrick Message-ID: Date: Thu, 1 Jun 2017 12:30:21 -0600 MIME-Version: 1.0 In-Reply-To: <1497996784-9177-1-git-send-email-jonathan.derrick@intel.com> Content-Type: text/plain; charset=utf-8 List-ID: +linux-pci On 06/20/2017 04:13 PM, Jon Derrick wrote: > Recent __call_srcu changes have exposed that we need to cleanup srcu > structures after pci_stop_root_bus calls into vmd_msi_free. > > Signed-off-by: Jon Derrick > Acked-by: Keith Busch > Cc: # 4.11 > --- > drivers/pci/host/vmd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c > index e27ad2a..642a182 100644 > --- a/drivers/pci/host/vmd.c > +++ b/drivers/pci/host/vmd.c > @@ -733,10 +733,10 @@ static void vmd_remove(struct pci_dev *dev) > struct vmd_dev *vmd = pci_get_drvdata(dev); > > vmd_detach_resources(vmd); > - vmd_cleanup_srcu(vmd); > sysfs_remove_link(&vmd->dev->dev.kobj, "domain"); > pci_stop_root_bus(vmd->bus); > pci_remove_root_bus(vmd->bus); > + vmd_cleanup_srcu(vmd); > vmd_teardown_dma_ops(vmd); > irq_domain_remove(vmd->irq_domain); > } >