From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f54.google.com ([209.85.215.54]:38012 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751115AbeECTuo (ORCPT ); Thu, 3 May 2018 15:50:44 -0400 Received: by mail-lf0-f54.google.com with SMTP id f18-v6so2086644lfc.5 for ; Thu, 03 May 2018 12:50:43 -0700 (PDT) Subject: Re: [PATCH v3 3/5] pcie-rcar: add R-Car gen3 PHY support From: Sergei Shtylyov To: horms@verge.net.au, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , devicetree@vger.kernel.org Cc: Mark Rutland References: Message-ID: Date: Thu, 3 May 2018 22:50:40 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-pci-owner@vger.kernel.org List-ID: On 05/03/2018 10:40 PM, Sergei Shtylyov wrote: > On R-Car gen3 SoCs the PCIe PHY has its own register region -- and I have > written a generic PHY driver for it, thus we need to add the corresponding > code in rcar_pcie_hw_init_gen3() and call devm_phy_optional_get() at the > driver's probing time, so that the existing R-Car gen3 device trees (not > having a PHY node) would still work (we only need to power up the PHY on > R-Car V3H). > > Signed-off-by: Sergei Shtylyov > Reviewed-by: Simon Horman Oops, forgot to add Rob's tag: Reviewed-by: Rob Herring MBR, Sergei