From: "Patel, Nirmal" <nirmal.patel@linux.intel.com>
To: Xinghui Li <korantwork@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
kbusch@kernel.org, jonathan.derrick@linux.dev,
lpieralisi@kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, Xinghui Li <korantli@tencent.com>
Subject: Re: [PATCH v4] PCI: vmd: Add the module param to adjust MSI mode
Date: Mon, 3 Apr 2023 14:00:12 -0700 [thread overview]
Message-ID: <a5f51ed8-b7b0-8f28-0e17-8f16ccb9abe1@linux.intel.com> (raw)
In-Reply-To: <CAEm4hYXwGuuZiKb9psXPyau+zKq-w=VboJEuYbS0FbY-iT-EmA@mail.gmail.com>
On 4/2/2023 7:34 AM, Xinghui Li wrote:
> On Thu, Mar 30, 2023 at 2:49 PM Patel, Nirmal
> <nirmal.patel@linux.intel.com> wrote:
>> How about adding a boolean flag by comparing user input for module
>> parameter msi_remap? and add the flag at
>>
>> - if (!(features & VMD_FEAT_CAN_BYPASS_MSI_REMAP) || msi_flag
>> || offset[0] || offset[1])
>>
>> Correct if I am wrong, but in this way we can cover all the cases.
>> If user adds msi_remap=on, msi_flag=true and enables remapping.
>> If user adds msi_remap=off, msi_flag=false and disables remapping.
>> If user doesn't add anything, msi_flag=false and decision will be
>> made same as current implementation. This will cover guest OS case
>> as well.
>>
> Sorry, I don't quite get your point. How is msi_flag assigned?
> Do you mean when msi_remap=no, the msi_flag is assigned as true?
> And msi_remap=off, the msi_flag is assigned as false?
>
> Thanks~
if msi_remap=on, then msi_flag=true;
if msi_remap=off, then msi_flag=false.
next prev parent reply other threads:[~2023-04-03 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 13:23 [PATCH v4] PCI: vmd: Add the module param to adjust MSI mode korantwork
2023-03-27 6:39 ` Xinghui Li
2023-03-28 21:34 ` Bjorn Helgaas
2023-03-29 8:57 ` Xinghui Li
2023-03-29 16:31 ` Bjorn Helgaas
2023-03-30 6:49 ` Patel, Nirmal
2023-04-02 14:34 ` Xinghui Li
2023-04-03 21:00 ` Patel, Nirmal [this message]
2023-04-02 15:02 ` Xinghui Li
2023-04-03 22:45 ` Bjorn Helgaas
2023-04-04 11:02 ` Xinghui Li
2023-04-17 9:15 ` Xinghui Li
2023-04-17 21:44 ` Bjorn Helgaas
2023-04-18 3:40 ` Xinghui Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5f51ed8-b7b0-8f28-0e17-8f16ccb9abe1@linux.intel.com \
--to=nirmal.patel@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@linux.dev \
--cc=kbusch@kernel.org \
--cc=korantli@tencent.com \
--cc=korantwork@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).