From: Jon Hunter <jonathanh@nvidia.com>
To: "Anand Moon" <linux.amoon@gmail.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"open list:PCI DRIVER FOR NVIDIA TEGRA"
<linux-tegra@vger.kernel.org>,
"open list:PCI DRIVER FOR NVIDIA TEGRA"
<linux-pci@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v1 1/2] PCI: tegra: Simplify clock handling by using clk_bulk*() functions
Date: Wed, 17 Sep 2025 14:44:38 +0100 [thread overview]
Message-ID: <a743fd19-d54b-450f-a4db-8efc21acf22a@nvidia.com> (raw)
In-Reply-To: <20250831190055.7952-2-linux.amoon@gmail.com>
On 31/08/2025 20:00, Anand Moon wrote:
> Currently, the driver acquires clocks and prepare/enable/disable/unprepare
> the clocks individually thereby making the driver complex to read.
>
> The driver can be simplified by using the clk_bulk*() APIs.
>
> Use:
> - devm_clk_bulk_get_all() API to acquire all the clocks
> - clk_bulk_prepare_enable() to prepare/enable clocks
> - clk_bulk_disable_unprepare() APIs to disable/unprepare them in bulk
>
> As part of this cleanup, the legacy has_cml_clk flag and explicit handling
> of individual clocks (pex, afi, pll_e, cml) are removed. Clock sequencing
> is now implicitly determined by the order defined in the device tree,
> eliminating hardcoded logic and improving maintainability.
What platforms have you tested this change on?
Thanks
Jon
--
nvpublic
next prev parent reply other threads:[~2025-09-17 13:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 19:00 [RFC v1 0/2] PCI: tegra: A couple of cleanups Anand Moon
2025-08-31 19:00 ` [RFC v1 1/2] PCI: tegra: Simplify clock handling by using clk_bulk*() functions Anand Moon
2025-09-17 13:44 ` Jon Hunter [this message]
2025-09-17 18:26 ` Anand Moon
2025-09-18 9:17 ` Jon Hunter
2025-09-18 15:06 ` Anand Moon
2025-09-18 16:46 ` Jon Hunter
2025-08-31 19:00 ` [RFC v1 2/2] PCI: tegra: Use readl_poll_timeout() for link status polling Anand Moon
2025-09-17 3:14 ` Mikko Perttunen
2025-09-17 7:45 ` Anand Moon
2025-09-18 1:25 ` Mikko Perttunen
2025-09-18 4:20 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a743fd19-d54b-450f-a4db-8efc21acf22a@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=bhelgaas@google.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox