From: Marek Vasut <marek.vasut@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>, linux-pci@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Wolfram Sang <wsa@the-dreams.de>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH V2] PCI: rcar: Add L1 link state fix into data abort hook
Date: Sun, 4 Oct 2020 16:10:39 +0200 [thread overview]
Message-ID: <a7af4067-d585-2e5e-cb1d-12954250dfd1@gmail.com> (raw)
In-Reply-To: <7ce58972-2946-0107-2298-c5a6f6e12feb@gmail.com>
On 9/27/20 10:29 AM, Sergei Shtylyov wrote:
[...]
>> the ARM 'imprecise external abort' handler is invoked.
>>
>> Just like other PCI controller drivers, here we hook the fault handler,
>> perform the fixup to help the controller enter L1 link state, and then
>> restart the instruction which triggered the fault. Since the controller
>
> If this is imprecise or async external abort, how we can re-execute
> the instruction that triggered the fault? It's been probably executed
> already, no?
It has been executed and triggered the fault, because it could not
access the data across the bus. Now the bus is back in operational
state, so restart the instruction, let it access the data and do its task.
[...]
next prev parent reply other threads:[~2020-10-04 14:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 16:09 [PATCH V2] PCI: rcar: Add L1 link state fix into data abort hook marek.vasut
2020-09-27 8:29 ` Sergei Shtylyov
2020-10-04 14:10 ` Marek Vasut [this message]
2020-09-28 9:35 ` Geert Uytterhoeven
2020-10-04 14:14 ` Marek Vasut
2020-10-05 7:31 ` Geert Uytterhoeven
2020-10-05 8:00 ` Marek Vasut
2020-10-05 8:07 ` Geert Uytterhoeven
2020-10-07 18:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7af4067-d585-2e5e-cb1d-12954250dfd1@gmail.com \
--to=marek.vasut@gmail.com \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sergei.shtylyov@gmail.com \
--cc=wsa@the-dreams.de \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).