linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Jim Quinlan <jim2101024@gmail.com>,
	linux-kernel@vger.kernel.org,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>,
	Florian Fainelli <f.fainelli@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-mips@linux-mips.org,
	linux-pci@vger.kernel.org, Kevin Cernekee <cernekee@gmail.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	bcm-kernel-feedback-list@broadcom.com,
	Gregory Fong <gregory.0xf0@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] SOC: brcmstb: add memory API
Date: Tue, 24 Oct 2017 17:23:24 -0700	[thread overview]
Message-ID: <a83617d0-8506-7fe4-2870-d9dbd9ffdb3f@gmail.com> (raw)
In-Reply-To: <1508868949-16652-2-git-send-email-jim2101024@gmail.com>

Hi Jim,

On 10/24/2017 11:15 AM, Jim Quinlan wrote:
> +#elif defined(CONFIG_MIPS)
> +int brcmstb_memory_phys_addr_to_memc(phys_addr_t pa)
> +{
> +	/* The logic here is fairly simple and hardcoded: if pa <= 0x5000_0000,
> +	 * then this is MEMC0, else MEMC1.
> +	 *
> +	 * For systems with 2GB on MEMC0, MEMC1 starts at 9000_0000, with 1GB
> +	 * on MEMC0, MEMC1 starts at 6000_0000.
> +	 */
> +	if (pa >= 0x50000000ULL)
> +		return 1;
> +	else
> +		return 0;
> +}
> +#endif

We may be missing an EXPORT_SYMBOL_GPL(brcmstb_memory_phys_to_addr_memc)
here?

Thanks!
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2017-10-25  0:23 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-24 18:15 Subject: PCI: brcmstb: Add Broadcom Settopbox PCIe support (V2) Jim Quinlan
2017-10-24 18:15 ` [PATCH 1/8] SOC: brcmstb: add memory API Jim Quinlan
2017-10-25  0:23   ` Florian Fainelli [this message]
2017-10-25 15:00     ` Jim Quinlan
2017-10-24 18:15 ` [PATCH 2/8] PCI: host: brcmstb: add DT docs for Brcmstb PCIe device Jim Quinlan
2017-10-27 14:37   ` Rob Herring
2017-10-30 14:07   ` Jonas Gorski
2017-10-24 18:15 ` [PATCH 3/8] PCI: host: brcmstb: Broadcom PCIe Host Controller Jim Quinlan
2017-10-24 21:15   ` Bjorn Helgaas
2017-10-25 17:42     ` Jim Quinlan
2017-10-24 18:15 ` [PATCH 4/8] PCI: host: brcmstb: add dma-ranges for inbound traffic Jim Quinlan
2017-10-25  9:46   ` David Laight
2017-10-25 16:00     ` Jim Quinlan
2017-10-24 18:15 ` [PATCH 5/8] PCI/MSI: Enable PCI_MSI_IRQ_DOMAIN support for MIPS Jim Quinlan
2017-10-24 18:15 ` [PATCH 6/8] PCI: host: brcmstb: add MSI capability Jim Quinlan
2017-10-24 18:57   ` Florian Fainelli
2017-10-25 15:28     ` Jim Quinlan
2017-10-25 17:23       ` Bjorn Helgaas
2017-10-25 18:40         ` Scott Branden
2017-10-25 20:16           ` Bjorn Helgaas
2017-10-25 21:11             ` Jim Quinlan
2017-10-25 13:22   ` Bjorn Helgaas
2017-10-25 15:50     ` Jim Quinlan
2017-10-24 18:15 ` [PATCH 7/8] MIPS: BMIPS: add PCI bindings for 7425, 7435 Jim Quinlan
2017-10-24 18:15 ` [PATCH 8/8] MIPS: BMIPS: enable PCI Jim Quinlan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a83617d0-8506-7fe4-2870-d9dbd9ffdb3f@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=catalin.marinas@arm.com \
    --cc=cernekee@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.0xf0@gmail.com \
    --cc=hch@lst.de \
    --cc=jim2101024@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=ralf@linux-mips.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).