From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Subject: Re: [PATCH 1/8] SOC: brcmstb: add memory API To: Jim Quinlan , linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Rob Herring , Brian Norris , Russell King , Robin Murphy , Christoph Hellwig , Florian Fainelli References: <1508868949-16652-1-git-send-email-jim2101024@gmail.com> <1508868949-16652-2-git-send-email-jim2101024@gmail.com> From: Florian Fainelli Message-ID: Date: Tue, 24 Oct 2017 17:23:24 -0700 MIME-Version: 1.0 In-Reply-To: <1508868949-16652-2-git-send-email-jim2101024@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-mips@linux-mips.org, linux-pci@vger.kernel.org, Kevin Cernekee , Ralf Baechle , bcm-kernel-feedback-list@broadcom.com, Gregory Fong , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+bjorn=helgaas.com@lists.infradead.org List-ID: Hi Jim, On 10/24/2017 11:15 AM, Jim Quinlan wrote: > +#elif defined(CONFIG_MIPS) > +int brcmstb_memory_phys_addr_to_memc(phys_addr_t pa) > +{ > + /* The logic here is fairly simple and hardcoded: if pa <= 0x5000_0000, > + * then this is MEMC0, else MEMC1. > + * > + * For systems with 2GB on MEMC0, MEMC1 starts at 9000_0000, with 1GB > + * on MEMC0, MEMC1 starts at 6000_0000. > + */ > + if (pa >= 0x50000000ULL) > + return 1; > + else > + return 0; > +} > +#endif We may be missing an EXPORT_SYMBOL_GPL(brcmstb_memory_phys_to_addr_memc) here? Thanks! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel