From: Andy Lutomirski <luto@kernel.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org, Yijing Wang <wangyijing@huawei.com>,
Andy Lutomirski <luto@kernel.org>
Subject: [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails
Date: Thu, 19 Nov 2015 08:08:20 -0800 [thread overview]
Message-ID: <a89313359d813d955da7235d9193aab01a1c05f9.1447949171.git.luto@kernel.org> (raw)
In-Reply-To: <cover.1447949171.git.luto@kernel.org>
In-Reply-To: <cover.1447949171.git.luto@kernel.org>
When _OSC fails and especially when it fails due to an invalid UUID,
it's helpful to show the UUID that we tried.
Signed-off-by: Andy Lutomirski <luto@kernel.org>
---
drivers/acpi/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
index 2177ef0b16e4..be2b164f8f2d 100644
--- a/drivers/acpi/bus.c
+++ b/drivers/acpi/bus.c
@@ -180,9 +180,9 @@ static void acpi_print_osc_error(acpi_handle handle,
int i;
if (ACPI_FAILURE(acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer)))
- printk(KERN_DEBUG "%s\n", error);
+ printk(KERN_DEBUG "%s: %s\n", context->uuid_str, error);
else {
- printk(KERN_DEBUG "%s: %s\n", (char *)buffer.pointer, error);
+ printk(KERN_DEBUG "%s (%s): %s\n", (char *)buffer.pointer, context->uuid_str, error);
kfree(buffer.pointer);
}
printk(KERN_DEBUG "_OSC request data:");
--
2.5.0
next prev parent reply other threads:[~2015-11-19 16:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 16:08 [PATCH 0/2] Minor _OSC error handling improvements Andy Lutomirski
2015-11-19 16:08 ` [PATCH 1/2] acpi: Tidy up _OSC error spacing Andy Lutomirski
2015-11-19 21:59 ` Andy Lutomirski
2015-11-20 1:01 ` Rafael J. Wysocki
2015-11-19 16:08 ` Andy Lutomirski [this message]
2015-11-19 22:00 ` [PATCH 2/2] acpi: Show _OSC UUID when _OSC fails Andy Lutomirski
2015-11-19 22:23 ` [PATCH 0/2] Minor _OSC error handling improvements Rafael J. Wysocki
2015-12-03 17:29 ` Bjorn Helgaas
2015-12-15 3:15 ` Andy Lutomirski
2015-12-15 16:10 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a89313359d813d955da7235d9193aab01a1c05f9.1447949171.git.luto@kernel.org \
--to=luto@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=wangyijing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).