Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	Linux ACPI <linux-acpi@vger.kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
	Linux PCI <linux-pci@vger.kernel.org>,
	 Mika Westerberg <westeri@kernel.org>
Subject: Re: [PATCH v1] ACPI: PM: Avoid initializing power management for absent devices
Date: Tue, 17 Nov 2026 16:53:16 +0100	[thread overview]
Message-ID: <a8a4b99f7f9c600035019f52a30681d4a7a9ca0b.camel@linux.intel.com> (raw)
In-Reply-To: <6047463.DvuYhMxLoT@rafael.j.wysocki>

On Tue, 2026-11-17 at 16:32 +0100, Rafael J. Wysocki wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> 
> Commit 2f4ddf2bd1ba ("ACPI: scan: Stop calling acpi_bus_init_power()
> early") removed a device presence check from acpi_bus_init_power()
> which
> in some cases causes power management to be initialized for an ACPI
> device object and never used going forward.  That in turn may prevent
> power management from working as expected for other devices.
> 
> Namely, if a given ACPI device object is not enabled according to its
> _STA, find_child_checks() will return an error for it which will
> prevent
> it from being used as an ACPI companion for a PCI device.  Thus if
> acpi_device_init_power() initializes power management for it and its
> initial power state turns out to be different from D3cold, it may
> stay
> in that power state forever.  If it has power resources and they are
> "on" during the initialization, they may be reference-counted and
> never
> turned off.  If they are shared with other devices, they will prevent
> power from going down after attempting to put the other devices into
> low-power states.
> 
> To prevent that from happening, restore the device presence check in
> acpi_bus_init_power(), but also adjust find_child_checks() to return
> an error for absent devices (instead of doing that for disabled
> devices)
> in accordance with acpi_bus_init_power() and the existing check in
> acpi_bus_attach().
> 
> Fixes: 2f4ddf2bd1ba ("ACPI: scan: Stop calling acpi_bus_init_power()
> early")
> Reported-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---

Tested-by: Alan Borzeszkowski <alan.borzeszkowski@linux.intel.com>

>  drivers/acpi/device_pm.c |    3 +++
>  drivers/acpi/glue.c      |    8 ++------
>  2 files changed, 5 insertions(+), 6 deletions(-)
> 
> --- a/drivers/acpi/device_pm.c
> +++ b/drivers/acpi/device_pm.c
> @@ -360,6 +360,9 @@ int acpi_bus_init_power(struct acpi_devi
>  	if (device->power.state != ACPI_STATE_UNKNOWN)
>  		return 0;
>  
> +	if (!acpi_device_is_present(device))
> +		return -ENXIO;
> +
>  	/*
>  	 * The ACPI device power state can be only initialized
> once.  If this
>  	 * fails, ACPI power management will not be used for the
> device going
> --- a/drivers/acpi/glue.c
> +++ b/drivers/acpi/glue.c
> @@ -109,14 +109,10 @@ static bool acpi_dev_has_children(struct
>  
>  static int find_child_checks(struct acpi_device *adev, bool
> check_children)
>  {
> -	unsigned long long sta;
> -	acpi_status status;
> -
>  	if (check_children && !acpi_dev_has_children(adev))
>  		return -ENODEV;
>  
> -	status = acpi_evaluate_integer(adev->handle, "_STA", NULL,
> &sta);
> -	if (status == AE_NOT_FOUND) {
> +	if (!acpi_has_method(adev->handle, METHOD_NAME__STA)) {
>  		/*
>  		 * Special case: backlight device objects without
> _STA are
>  		 * preferred to other objects with the same _ADR
> value, because
> @@ -128,7 +124,7 @@ static int find_child_checks(struct acpi
>  		return FIND_CHILD_MIN_SCORE;
>  	}
>  
> -	if (ACPI_FAILURE(status) || !(sta &
> ACPI_STA_DEVICE_ENABLED))
> +	if (!acpi_device_is_present(adev))
>  		return -ENODEV;
>  
>  	/*
> 
> 

      reply	other threads:[~2026-11-17 15:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 15:32 [PATCH v1] ACPI: PM: Avoid initializing power management for absent devices Rafael J. Wysocki
2026-11-17 15:53 ` Alan Borzeszkowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8a4b99f7f9c600035019f52a30681d4a7a9ca0b.camel@linux.intel.com \
    --to=alan.borzeszkowski@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=westeri@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox