From: Hans Zhang <18255117159@163.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: lpieralisi@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com,
manivannan.sadhasivam@linaro.org, kw@linux.com, robh@kernel.org,
thomas.richard@bootlin.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: dwc: ep: Use FIELD_GET()
Date: Thu, 24 Apr 2025 22:39:17 +0800 [thread overview]
Message-ID: <a9092968-9d19-4d5e-89bb-1063a3d8d93b@163.com> (raw)
In-Reply-To: <aApANPRB7f1mOWDa@ryzen>
On 2025/4/24 21:44, Niklas Cassel wrote:
> On Mon, Apr 21, 2025 at 07:45:48PM +0800, Hans Zhang wrote:
>> Use FIELD_GET() and FIELD_PREP() to remove dependences on the field
>> position, i.e., the shift value. No functional change intended.
>
> Nit: It is a little bit misleading to write "Use ... FIELD_PREP()"
> since this patch actually never uses FIELD_PREP().
>
> Reviewed-by: Niklas Cassel <cassel@kernel.org>
Hi Niklas,
Thank you very much for your review. I think Mani can help me modify it
when merging to the temporary branch.
Best regards,
Hans
prev parent reply other threads:[~2025-04-24 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 11:45 [PATCH] PCI: dwc: ep: Use FIELD_GET() Hans Zhang
2025-04-24 13:44 ` Niklas Cassel
2025-04-24 14:39 ` Hans Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9092968-9d19-4d5e-89bb-1063a3d8d93b@163.com \
--to=18255117159@163.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=thomas.richard@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox