From: Zijun Hu <zijun_hu@icloud.com>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Jonathan Corbet" <corbet@lwn.net>,
linux-pci@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Zijun Hu" <quic_zijuhu@quicinc.com>
Subject: Re: [PATCH] PCI: endpoint: Remove API devm_pci_epc_destroy()
Date: Mon, 17 Feb 2025 20:06:42 +0800 [thread overview]
Message-ID: <a99e4576-ca9a-4b28-9a5b-242184de852c@icloud.com> (raw)
In-Reply-To: <20250214154007.tg3bzi5berkk45wk@thinkpad>
On 2025/2/14 23:40, Manivannan Sadhasivam wrote:
> On Mon, Feb 10, 2025 at 08:39:53PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@quicinc.com>
>>
>> Static devm_pci_epc_match() is only invoked by API devm_usb_put_phy(), and
> devm_usb_put_phy()? Did you mean to say 'devm_pci_epc_destroy()'?
>
yes. it is devm_pci_epc_destroy().
my mistake, thank you for pointing out this.
will correct in v2. (^^)
>> the API has not had callers since 2017-04-10 when it was introduced.
>>
>> Remove both the API and the static function.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
> With above fixup,
>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>
> - Mani
prev parent reply other threads:[~2025-02-17 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 12:39 [PATCH] PCI: endpoint: Remove API devm_pci_epc_destroy() Zijun Hu
2025-02-14 15:40 ` Manivannan Sadhasivam
2025-02-17 12:06 ` Zijun Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a99e4576-ca9a-4b28-9a5b-242184de852c@icloud.com \
--to=zijun_hu@icloud.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_zijuhu@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox