linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrea della Porta <andrea.porta@suse.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Andrea della Porta <andrea.porta@suse.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-gpio@vger.kernel.org,
	Masahiro Yamada <masahiroy@kernel.org>,
	kernel-list@raspberrypi.com
Subject: Re: [PATCH v9 -next 08/12] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5
Date: Thu, 8 May 2025 23:11:14 +0200	[thread overview]
Message-ID: <aB0d8kNVtAEoW8Ts@apocalypse> (raw)
In-Reply-To: <779ae10a-3174-4dbb-9130-008393b59745@broadcom.com>

Hi Florian,

On 19:10 Wed 07 May     , Florian Fainelli wrote:
> 
> 
> On 5/7/2025 4:13 PM, 'Andrea della Porta' via BCM-KERNEL-FEEDBACK-LIST,PDL
> wrote:
> > Hi Florian
> > 
> > On 09:32 Wed 07 May     , Florian Fainelli wrote:
> > > 
> > > 
> > > On 5/6/2025 10:49 PM, Andrea della Porta wrote:
> > > > Hi Florian,
> > > > 
> > > > On 20:53 Tue 22 Apr     , Andrea della Porta wrote:
> > > > > The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz.
> > > > > Add clk_rp1_xosc node to provide that.
> > > > > 
> > > > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> > > > > Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> > > > 
> > > > A gentle reminder for patches 8 through 12 of this series, which I guess
> > > > would ideally be taken by you. Since the merge window is approaching, do
> > > > you think it's feasible to iterate a second pull request to Arnd with my
> > > > patches too?
> > > > 
> > > > With respect to your devicetree/next branch, my patches have the following
> > > > conflicts:
> > > > 
> > > > PATCH 9:
> > > > - arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts: &pcie1 and &pcie2
> > > >     reference at the end, my patch was rebased on linux-next which has them
> > > >     while your devicetree branch has not. This is trivial to fix too.
> > > > 
> > > > PATCH 9 and 10:
> > > > - arch/arm64/boot/dts/broadcom/Makefile on your branch has a line recently
> > > >     added by Stefan's latest patch for RPi2. The fix is trivial.
> > > > 
> > > > PATCH 11 and 12:
> > > > - arch/arm64/configs/defconfig: just a couple of fuzz lines.
> > > > 
> > > > Please let me know if I should resend those patches adjusted for your tree.
> > > 
> > > Yes please resend them today or tomorrow so I can send them the following
> > > day. Thanks
> > 
> > Sorry, what's the best wasy to provide the updated patch 8 to 12 to you?
> > 
> > 1) Resend the entire patchset (V10) with relevant patches updated
> > 2) Send only updated patches 8 through 12 (maybe as an entirely new patchset with
> >     only those specific patches)
> 
> Either of those two options would work. Maybe let's do option 2) in the
> interest of keeping the traffic low for people.

Could you please take a look at this:

https://lore.kernel.org/all/aBxtyvI3LUaM3P00@apocalypse/#t

besides patches 8 through 12, would you like to take also binding patches + clock
driver (patches 1 to 4, if Linux Walleij is not willing to take patch 2 himself),
and maybe also misc driver and its dts (patches 6 and 7 unless Greg has different
ideas)? I know this is almost the entire patchset, but it's getting hard to escape
the dependency maze.
I'm open to any alternative solutions, more details in the link above.

Many thanks,
Andrea

> -- 
> Florian
> 

  reply	other threads:[~2025-05-08 21:09 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-22 18:53 [PATCH v9 -next 00/12] Add support for RaspberryPi RP1 PCI device using a DT overlay Andrea della Porta
2025-04-22 18:53 ` [PATCH v9 -next 01/12] dt-bindings: clock: Add RaspberryPi RP1 clock bindings Andrea della Porta
2025-04-22 18:53 ` [PATCH v9 -next 02/12] dt-bindings: pinctrl: Add RaspberryPi RP1 gpio/pinctrl/pinmux bindings Andrea della Porta
2025-04-22 18:53 ` [PATCH v9 -next 03/12] dt-bindings: misc: Add device specific bindings for RaspberryPi RP1 Andrea della Porta
2025-04-22 18:53 ` [PATCH v9 -next 04/12] clk: rp1: Add support for clocks provided by RP1 Andrea della Porta
2025-04-22 19:14   ` Stefan Wahren
2025-05-06 20:03   ` Andrea della Porta
2025-05-07 19:44     ` Stephen Boyd
2025-05-08  8:39       ` Andrea della Porta
2025-05-07 20:01   ` Stephen Boyd
2025-05-08 20:22     ` Andrea della Porta
2025-05-08 21:28     ` Andrea della Porta
2025-04-22 18:53 ` [PATCH v9 -next 05/12] pinctrl: rp1: Implement RaspberryPi RP1 gpio support Andrea della Porta
2025-04-22 18:53 ` [PATCH v9 -next 06/12] arm64: dts: rp1: Add support for RaspberryPi's RP1 device Andrea della Porta
2025-04-22 18:53 ` [PATCH v9 -next 07/12] misc: rp1: RaspberryPi RP1 misc driver Andrea della Porta
2025-04-25 13:20   ` Greg Kroah-Hartman
2025-04-22 18:53 ` [PATCH v9 -next 08/12] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5 Andrea della Porta
2025-05-06 20:49   ` Andrea della Porta
2025-05-07  7:32     ` Florian Fainelli
2025-05-07 14:13       ` Andrea della Porta
2025-05-07 17:10         ` Florian Fainelli
2025-05-08 21:11           ` Andrea della Porta [this message]
2025-05-12 13:06             ` Florian Fainelli
     [not found]       ` <CAO50JKVF6x_=MUuzjhdK0QotcdUgHysMb9v1g0UvWjaJF2fjDA@mail.gmail.com>
     [not found]         ` <48AFA657-5683-42A4-888E-3E98A515F3B1@broadcom.com>
2025-05-12 16:42           ` Andrea della Porta
2025-05-26 14:06             ` Matthias Brugger
2025-05-27 16:18               ` Florian Fainelli
2025-05-27 21:24                 ` Andrea della Porta
2025-05-27 21:26                   ` Florian Fainelli
2025-04-22 18:53 ` [PATCH v9 -next 09/12] arm64: dts: broadcom: Add board DTS for Rpi5 which includes RP1 node Andrea della Porta
2025-04-22 18:53 ` [PATCH v9 -next 10/12] arm64: dts: broadcom: Add overlay for RP1 device Andrea della Porta
2025-04-25 10:08   ` Florian Fainelli
2025-04-22 18:53 ` [PATCH v9 -next 11/12] arm64: defconfig: Enable RP1 misc/clock/gpio drivers Andrea della Porta
2025-04-25 10:07   ` Florian Fainelli
2025-04-22 18:53 ` [PATCH v9 -next 12/12] arm64: defconfig: Enable OF_OVERLAY option Andrea della Porta
2025-04-25 10:07   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aB0d8kNVtAEoW8Ts@apocalypse \
    --to=andrea.porta@suse.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=kernel-list@raspberrypi.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).