From: Lukas Wunner <lukas@wunner.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Keith Busch <kbusch@kernel.org>,
Dave Jiang <dave.jiang@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] PCI: Fix lock symmetry in pci_slot_unlock()
Date: Wed, 30 Apr 2025 15:20:43 +0200 [thread overview]
Message-ID: <aBIjqwn7Txl6TuP0@wunner.de> (raw)
In-Reply-To: <20250430083526.4276-1-ilpo.jarvinen@linux.intel.com>
On Wed, Apr 30, 2025 at 11:35:26AM +0300, Ilpo Järvinen wrote:
> The commit a4e772898f8b ("PCI: Add missing bridge lock to
> pci_bus_lock()") made the lock function to call depend on
> dev->subordinate but left pci_slot_unlock() unmodified creating locking
> asymmetry compared with pci_slot_lock().
Worth noting that this isn't just for symmetry: It seems the bridge
is unlocked twice because pci_bus_unlock() unlocks bus->self and
pci_slot_unlock() then unconditionally unlocks the same bridge device
again.
Thanks,
Lukas
prev parent reply other threads:[~2025-04-30 13:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 8:35 [PATCH 1/1] PCI: Fix lock symmetry in pci_slot_unlock() Ilpo Järvinen
2025-04-30 13:20 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBIjqwn7Txl6TuP0@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox