From: Lukas Wunner <lukas@wunner.de>
To: "Moshe Shemesh" <moshe@nvidia.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Keith Busch <kbusch@kernel.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: Fix missing update in pci_slot_unlock() after locking changes
Date: Sun, 4 May 2025 19:53:24 +0200 [thread overview]
Message-ID: <aBeplBA5FLjjXktu@wunner.de> (raw)
In-Reply-To: <1746376292-1827952-1-git-send-email-moshe@nvidia.com>
On Sun, May 04, 2025 at 07:31:32PM +0300, Moshe Shemesh wrote:
> The cited patch updated pci_slot_lock(), pci_slot_trylock(),
> pci_bus_lock(), and pci_bus_trylock() recursive locking, and adjusted
> pci_bus_unlock() accordingly. However, it missed updating
> pci_slot_unlock(), which may lead to attempting to unlock the
> subordinate bridge's device lock twice.
>
> Fixes: a4e772898f8b ("PCI: Add missing bridge lock to pci_bus_lock()")
> Signed-off-by: Moshe Shemesh <moshe@nvidia.com>
Ilpo already submitted an identical patch on April 30:
https://lore.kernel.org/r/20250430083526.4276-1-ilpo.jarvinen@linux.intel.com/
next prev parent reply other threads:[~2025-05-04 17:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-04 16:31 [PATCH] PCI: Fix missing update in pci_slot_unlock() after locking changes Moshe Shemesh
2025-05-04 17:53 ` Lukas Wunner [this message]
2025-05-04 20:16 ` Moshe Shemesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aBeplBA5FLjjXktu@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=moshe@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox