From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11ED1198823 for ; Tue, 6 May 2025 20:47:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746564465; cv=none; b=Q+rcbo1l8A9BRKjb1v7uk2Nvy6oaLW7xKDqZVays3pn7ld9a0i5MW4Ily46J2cM4DzkYEvn1nroK1IskHlxz7IP2UeQ3l7uSodIbsdJBKoOre0uxXJKgjxYxLOppkeAmy2pGgE4p87RpX/KokaKHDaRDaITsyG/FIrethsWVlWM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746564465; c=relaxed/simple; bh=HoSPNJpzAj/UHgTcCm+14l6OqVn0UOHxo2Yn1NKbwwc=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RkdbSQNeyCqNHyPbd+g4Y3tCbc/E7FafQgqWU0DhpcDejNuiYfG1whH1GXy7Pk24qAVLqTRFzr0iCENkfTvpfTFzLPPkua9Pr5lvBtS2GFE95T2QNDu3i3e1O2cOa0UGlBgWKPH7RI3XrX6yU52uualW/fPUJSColWWqiMUhpAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=gBDh+uwv; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="gBDh+uwv" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5e5deb6482cso541161a12.1 for ; Tue, 06 May 2025 13:47:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1746564459; x=1747169259; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Pi47gK8MYhyGIqIdKO9+ShtObSRr4S3t2PvkIQxuaXA=; b=gBDh+uwvqOEb3fLM4eNviuqwt3dZpUuSnrvnEac6apQCsRqOMi0E89SJlebAeuGJlu 29jc5MflQOtiZdAlaW7UueewAZmgrE7KnNq3XfTDdFzT3YWTZmNXIUKCYiuWnULLyGal HOPF+AUrGqI0fCB5N+IkmdMarL8VDvUzvvvTcTaRcoK//+MtWrgjrxAI7Qv4u3atBkOf L5SYGvvF2J1mNeaNHcivYH2+j+AS2Gk2KTJEUPV/l7xQuQcQmwyQ87PtJPmRQHNOfv8t H8FGhg7pxvHH1k/TkfPJAiv/OHRQqJTTOqVhL9XwbUWPx+dTUKJYNLazYYmAXYEp3B4Y GCoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746564459; x=1747169259; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Pi47gK8MYhyGIqIdKO9+ShtObSRr4S3t2PvkIQxuaXA=; b=s8ew15myBIZ2a9C//f+YREMDHj6Wiaw63G47G69vi2Gn/NHXpIWnXVOidUVip8nGZY 2zE0XfPbCsfwJOQoZzLZztNZ8CZdF0+baepxY7osXEHLgOAqONIry5fmtTS6r8eqFRzK 7k06t+gR8cItNvNyh2jeX9I6B5T5hpPYdM+MW00ofFe4E/D4pbK8ucoDiNtNWsFOybmB dqb0WnJdosUbBOthpLnE2+7Jl1VP13X8W0Pjbequ5rSaxlXOk2fekhm0nsKq6ms0q2UB jO+21ERGPrS2TozKjUxOQfd86erhs5OBadGYO4KrL6zgvi8YwBrdB6CikeA7cyMP62kh ffzA== X-Forwarded-Encrypted: i=1; AJvYcCX/CDUDmjMOAJ8t1LZ+vPSsQTNPGIKwQill1TYcXYxY73yQ+kOJp88OeDnvlj/8SpdZ0J7FnQV9ERA=@vger.kernel.org X-Gm-Message-State: AOJu0YxXq7+1ztnwd06J2ys/Z/433Nyd9aTPva/zh4pmfyXsrCvkcGVs 5vV80LXB6hy3UoR8PdLjS1KO+ccg8sdgo2gcjGBB6VJl2yorkd7bEcE2tE6enNE= X-Gm-Gg: ASbGncuknHOdwqHZMRKbrFa+I1GG7ME1XMr48l4AOm0ev9cFsnUs70geUcnpBdvYU1c HdMGy+0sd6tHWV/gvd3V2oDL6frknKX5AietOaqnPK2/nGYVT6OVBkhHPiFkGos/FK80U6rDO2G ZTt63KXjRxD+2/38b21xhjHRJoZTQZ44sjk3ojHH50pJI2nQGdv1g1DddomnIKRK60V0eD+wpgH +cXBTrmLK6RdkzLBv13mFnmduU/KTjKDem4eifxkXb1Mk5VSdcisYSnQycbpmEWyD7r7vT6SOq/ M4e+vVe4YWUc+QqXyM+XQ7eaRDAdSkT2ObB5xluFXRddpgJxby09bhtPx7v3oRWdczAW8N4= X-Google-Smtp-Source: AGHT+IGdejKWhHgobANcBR0HkA6BZ7303l9tnuRyiuAvIspM7E6yB+9PaEvl5m9+eOZo13IwvIZIoA== X-Received: by 2002:a17:907:6d23:b0:ac7:3929:25fa with SMTP id a640c23a62f3a-ad1e79a28bamr109364566b.30.1746564459254; Tue, 06 May 2025 13:47:39 -0700 (PDT) Received: from localhost (93-44-188-26.ip98.fastwebnet.it. [93.44.188.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ad189540d5bsm770703266b.176.2025.05.06.13.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 May 2025 13:47:38 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Tue, 6 May 2025 22:49:07 +0200 To: Andrea della Porta Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com, Matthias Brugger Subject: Re: [PATCH v9 -next 08/12] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5 Message-ID: References: <38514415df9c174be49e72b88410d56c8de586c5.1745347417.git.andrea.porta@suse.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38514415df9c174be49e72b88410d56c8de586c5.1745347417.git.andrea.porta@suse.com> Hi Florian, On 20:53 Tue 22 Apr , Andrea della Porta wrote: > The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz. > Add clk_rp1_xosc node to provide that. > > Signed-off-by: Andrea della Porta > Reviewed-by: Florian Fainelli A gentle reminder for patches 8 through 12 of this series, which I guess would ideally be taken by you. Since the merge window is approaching, do you think it's feasible to iterate a second pull request to Arnd with my patches too? With respect to your devicetree/next branch, my patches have the following conflicts: PATCH 9: - arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts: &pcie1 and &pcie2 reference at the end, my patch was rebased on linux-next which has them while your devicetree branch has not. This is trivial to fix too. PATCH 9 and 10: - arch/arm64/boot/dts/broadcom/Makefile on your branch has a line recently added by Stefan's latest patch for RPi2. The fix is trivial. PATCH 11 and 12: - arch/arm64/configs/defconfig: just a couple of fuzz lines. Please let me know if I should resend those patches adjusted for your tree. Many thanks, Andrea > --- > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > index 34470e3d7171..6ea3c102e0d6 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > @@ -16,6 +16,13 @@ chosen: chosen { > stdout-path = "serial10:115200n8"; > }; > > + clk_rp1_xosc: clock-50000000 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-output-names = "rp1-xosc"; > + clock-frequency = <50000000>; > + }; > + > /* Will be filled by the bootloader */ > memory@0 { > device_type = "memory"; > -- > 2.35.3 >