From: Christoph Hellwig <hch@infradead.org>
To: Daisuke Matsuda <dskmtsd@gmail.com>
Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org, leon@kernel.org,
jgg@ziepe.ca, akpm@linux-foundation.org, jglisse@redhat.com,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
zyjzyj2000@gmail.com
Subject: Re: [PATCH] mm/hmm: Allow hmm_dma_map_alloc() to tolerate NULL device
Date: Fri, 23 May 2025 07:48:16 -0700 [thread overview]
Message-ID: <aDCKsK2-zRkqge64@infradead.org> (raw)
In-Reply-To: <20250523143537.10362-1-dskmtsd@gmail.com>
On Fri, May 23, 2025 at 02:35:37PM +0000, Daisuke Matsuda wrote:
> Some drivers (such as rxe) may legitimately call hmm_dma_map_alloc() with a
> NULL device pointer,
No, they may not. If something has no device with physical DMA
capabilities, it has not business calling into it.
next prev parent reply other threads:[~2025-05-23 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-23 14:35 [PATCH] mm/hmm: Allow hmm_dma_map_alloc() to tolerate NULL device Daisuke Matsuda
2025-05-23 14:48 ` Christoph Hellwig [this message]
2025-05-23 15:38 ` Daisuke Matsuda
2025-05-23 15:42 ` Christoph Hellwig
2025-05-23 15:56 ` Daisuke Matsuda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aDCKsK2-zRkqge64@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dskmtsd@gmail.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).