From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F2DF141987 for ; Wed, 4 Jun 2025 17:24:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749057873; cv=none; b=IiOqo4Ew6UwnPm4Pjq81xKvOjDgaBbJOdmhf519xmfoQlC3gU7ru8qNhM60rWs9a0n4szE+kIU2s9lB/dpmdCCaKRm219U+Fd0N7BUEVwoCPZJWlZ69KqE47H2XoqIAwUygQtjZqjzBEi++Fzk8SMMLY513TOXs58TPgaF/+lBU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749057873; c=relaxed/simple; bh=YI5mFLWc53VgL5FQ8bsi7skJV4Aik/gLWAIifjuXyD0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VVmdhe69jnXBh26cAZQulyXDfmsByFrsyCfJupsmNGofCPIWqUha0SOj2yBngBWNHibdXJ5kig865xDdfV+QPcbal0yeZ8uvrOqTmikF9ldboWq+NilIbRifZFxAqLpEveQzCC694LGo/MeuOcPePpMAZAPwmtsaA4s5tl0vQNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AMzyjRze; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AMzyjRze" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-ad574992fcaso13224166b.1 for ; Wed, 04 Jun 2025 10:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749057870; x=1749662670; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5Rx6gG3qsE4+StDVhI8Ouf35YkFJYK0JatY+uS2ZTLI=; b=AMzyjRze6N+CdUwAkkXRMLQyhnHh9VDOOuZs+j+q4uiq3s6KdS9GFEJq21qhfvtPbT fIWXNFaXLOTxIwjTCNkfIvXcpEosYQQPg5iJzgep+ehIulc0V+bVRYGCnkBxwHkMDqqB bqwXc7EHXMYSqAccUPKt6OAqNcatvCVEbAxbEjlEajeTA+LU1c29uD9TusSxu+t7bPkY R9iG7DILGEi3VM/KXvE1u565yUR7oWFZXWikYkBf0VF9Vd2sh16GqmUi0UcvdC7N1wQ0 5kGY9jSP8ABtAdXSTZbucGAFCNzT4cj92axqg3sGplWAFRYqluAkGP7o3TQ+dDlxmpFP x60w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749057870; x=1749662670; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Rx6gG3qsE4+StDVhI8Ouf35YkFJYK0JatY+uS2ZTLI=; b=g/FP8YiERRhUQibaRR2ULje93z+7qZ80s4hC+5FJ+tK6tlPzY4A3YCf3aHfwevk1tn kf239GocuWUnFzutfaKsRg8dT53ITyh8CQwr+zxZlinBgXunN2514yybO5ZoC9gCC4y0 CSOzjYHAqJCosp/8/tgfCNOkR+k547tMw25PR4UUBIAOPoeL4xSlpD1cocAqEFiBLz00 5b4gYzCGxaHFIjL8cG9YBTqec/FH5HwydCQI4WTJUqFkto7MGaQErVvsQ61Jk2/vMza8 yoy+ZlEiUM5wloaXRdwDub/5AmibNL1gobosQu9g6ZRGxa01lfpPgjl4fb3T78sjNJef zjnA== X-Forwarded-Encrypted: i=1; AJvYcCV/6DBt+b9fBQV88F6LVbe5VQ0ZmEIA1wKIE8AqzjkvRJZ/vlBcv5ojoNdr9aRj5ZS+3CORoB13K7o=@vger.kernel.org X-Gm-Message-State: AOJu0YxqhjnjrWxoSEUzmFkQBmkp/StmP2BtpQK1oFdU24nLxNOPcvw1 IqGR3Y6KHzzTjW0tDAQFnCoEgHYCtyA+IwRhpB/SXrt4aLQurc1FRt4RxAZFECJBloQ= X-Gm-Gg: ASbGncvfpUPsvO7h9Z4gUnf2I3ByxFkGz+yFZDjeA+SR0tRjxpP1kFYsbteE4wja4GA EHjGdK5aTuu+2LwqyX07ni5WYEoK2R3l/NKgfWVFXv8aHQ5qwdNkx/oc8uZtFrq5soBzKyXDeUt gvEFQ2JDriqIhH/FDecPWHH8saUiVHQxBMb6RpVzU8dQ7HE0IEDy2YlT8rPiBP5UVw2LCB6r8+9 BGPYWvqCLMVm9fgteJaWCTaYo2Bn6Pwjk3qFTcfMdzZraxry7HAnifgyxLwPDjdq7S85vH5sf6b xkdeqZhA80HH6+oSZ29uTdYqfAb/YeD7RRJozyRokJmBLkwoYgsWr48= X-Google-Smtp-Source: AGHT+IH+P0WeybYhDtQX0mOthiBD4sJUH0iS4YBwLkOkmeksTa502is8e50CYha9Oj5de4xARn23DA== X-Received: by 2002:a17:907:3e11:b0:ad8:89f8:3f66 with SMTP id a640c23a62f3a-addf8cd2118mr358479966b.21.1749057869894; Wed, 04 Jun 2025 10:24:29 -0700 (PDT) Received: from localhost ([41.210.155.222]) by smtp.gmail.com with UTF8SMTPSA id a640c23a62f3a-ada5d7fef72sm1127136966b.34.2025.06.04.10.24.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jun 2025 10:24:29 -0700 (PDT) Date: Wed, 4 Jun 2025 20:24:23 +0300 From: Dan Carpenter To: "Bowman, Terry" Cc: PradeepVineshReddy.Kodamati@amd.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, dan.j.williams@intel.com, bhelgaas@google.com, bp@alien8.de, ming.li@zohomail.com, shiju.jose@huawei.com, Smita.KoralahalliChannabasappa@amd.com, kobayashi.da-06@fujitsu.com, yanfei.xu@intel.com, rrichter@amd.com, peterz@infradead.org, colyli@suse.de, uaisheng.ye@intel.com, fabio.m.de.francesco@linux.intel.com, ilpo.jarvinen@linux.intel.com, yazen.ghannam@amd.com, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v9 03/16] CXL/AER: Introduce kfifo for forwarding CXL errors Message-ID: References: <20250603172239.159260-1-terry.bowman@amd.com> <20250603172239.159260-4-terry.bowman@amd.com> <1f719cfd-2c2b-4431-a370-290a865b0bf2@amd.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f719cfd-2c2b-4431-a370-290a865b0bf2@amd.com> On Wed, Jun 04, 2025 at 09:37:02AM -0500, Bowman, Terry wrote: > > > On 6/4/2025 1:01 AM, Dan Carpenter wrote: > > On Tue, Jun 03, 2025 at 12:22:26PM -0500, Terry Bowman wrote: > >> +static struct work_struct cxl_prot_err_work; > >> +static DECLARE_WORK(cxl_prot_err_work, cxl_prot_err_work_fn); > >> + > >> int cxl_ras_init(void) > >> { > >> - return cxl_cper_register_prot_err_work(&cxl_cper_prot_err_work); > >> + int rc; > >> + > >> + rc = cxl_cper_register_prot_err_work(&cxl_cper_prot_err_work); > >> + if (rc) > >> + pr_err("Failed to register CPER AER kfifo (%x)", rc); > > This shouldn't return rc;? > > This was implemented to allow for native CXL handling initialization even if > FW-first (CPER) initialization fails. This can be changed to return rc. No no. I'm fine with it either way so long as it's deliberate. But maybe add a comment if we can continue. rc = cxl_cper_register_prot_err_work(&cxl_cper_prot_err_work); if (rc) { pr_err("Failed to register CPER AER kfifo (%x)", rc); /* Continuing regardless. Thanks. */ } rc = cxl_register_prot_err_work(&cxl_prot_err_work); regards, dan carpenter