Re: [RFC PATCH v5 2/4] PCI: rockchip: Set Target Link Speed before retraining

Geraldo Nascimento
2025-06-20T12:43:35Z

On Fri, Jun 20, 2025 at 01:33:11PM +0100, Robin Murphy wrote:
> On 2025-06-13 6:03 pm, Geraldo Nascimento wrote:
> > Current code may fail Gen2 retraining if Target Link Speed
> > is set to 2.5 GT/s in Link Control and Status Register 2.
> > Set it to 5.0 GT/s accordingly.
>
> I have max-link-speed overridden to 2 in my local DTB, and indeed this
> seems to make my NVMe report a 5.0 GT/s link where previously it was
> still downgrading to 2.5, so:
>
> Tested-by: Robin Murphy <robin.murphy@arm.com>
>

Hi Robin,

thanks for the testing, I'll include the tag in v6 once Bjorn gets back
to me on the 16-bit adjacent registers problem.

Geraldo Nascimento