Re: [RFC PATCH v5 4/4] phy: rockchip-pcie: Adjust read mask and write

Geraldo Nascimento
2025-06-20T18:36:08Z

On Fri, Jun 20, 2025 at 03:19:06PM +0100, Robin Murphy wrote:
> Which write mask? Certainly not PHY_CFG_WR_MASK... However as this
> definition is unused since 64cdc0360811 ("phy: rockchip-pcie: remove
> unused phy_rd_cfg function"), I don't see much point in touching it
> other than to remove it entirely. If it is the case that only the
> address field is significant for whatever a "read" operation actually
> means, well then that's just another job for ADDR_MASK (which I guess is
> what the open-coded business with PHY_CFG_PLL_LOCK is actually doing...)

Just for the sake of posterity, Robin is right here, PHY_CFG_WR_MASK is
just hardcoded to 1, and PHY_CFG_RD_MASK should have been the same
as PHY_CFG_ADDR_MASK as Robin correctly pointed out.

Moot point since I already agreed with Bjorn and Robin to drop the read
define, and Robin was kind enough to track the exact commit where the
corresponding read function was removed. I re-injected that function
from BSP into mainline for my own debugging though, that's why I caught
the typo.

Thanks,
Geraldo Nascimento

>
> Thanks,
> Robin.