From: Danilo Krummrich <dakr@kernel.org>
To: Alice Ryhl <aliceryhl@google.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, tmgross@umich.edu,
david.m.ertman@intel.com, ira.weiny@intel.com, leon@kernel.org,
kwilczynski@kernel.org, bhelgaas@google.com,
rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, Dave Airlie <airlied@redhat.com>,
Simona Vetter <simona.vetter@ffwll.ch>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: Re: [PATCH v2 2/4] rust: devres: replace Devres::new_foreign_owned()
Date: Mon, 23 Jun 2025 14:41:49 +0200 [thread overview]
Message-ID: <aFlLjQFZ8gzh5Mz6@cassiopeiae> (raw)
In-Reply-To: <aFlA92ooeQsSThLh@google.com>
On Mon, Jun 23, 2025 at 11:56:39AM +0000, Alice Ryhl wrote:
> On Sun, Jun 22, 2025 at 06:40:39PM +0200, Danilo Krummrich wrote:
> > +pub fn register<T, E>(dev: &Device<Bound>, data: impl PinInit<T, E>, flags: Flags) -> Result
> > +where
> > + T: 'static,
> > + Error: From<E>,
> > +{
> > + let data = KBox::pin_init(data, flags)?;
>
> Wouldn't we also want to expose the ForeignOwnable version? It seems
> likely someone would want to avoid the allocation.
Allowing other things than Box changes the semantics of the API. For instance,
if it'd be a reference counted thing (e.g. Arc), it would basically mean "please
make this object live *at least* as long as the device is bound".
Before considering to allow such things, I really want a potential user to
present a valid use-case for that.
next prev parent reply other threads:[~2025-06-23 12:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-22 16:40 [PATCH v2 0/4] Improvements for Devres Danilo Krummrich
2025-06-22 16:40 ` [PATCH v2 1/4] rust: revocable: support fallible PinInit types Danilo Krummrich
2025-06-22 20:23 ` Benno Lossin
2025-06-22 20:30 ` Miguel Ojeda
2025-06-23 11:53 ` Alice Ryhl
2025-06-22 16:40 ` [PATCH v2 2/4] rust: devres: replace Devres::new_foreign_owned() Danilo Krummrich
2025-06-22 20:25 ` Benno Lossin
2025-06-23 11:56 ` Alice Ryhl
2025-06-23 12:41 ` Danilo Krummrich [this message]
2025-06-22 16:40 ` [PATCH v2 3/4] rust: devres: get rid of Devres' inner Arc Danilo Krummrich
2025-06-22 20:45 ` Benno Lossin
2025-06-22 21:09 ` Danilo Krummrich
2025-06-23 1:54 ` Boqun Feng
2025-06-24 15:18 ` Danilo Krummrich
2025-06-24 15:46 ` Boqun Feng
2025-06-24 16:15 ` Danilo Krummrich
2025-06-24 16:20 ` Danilo Krummrich
2025-06-24 16:37 ` Boqun Feng
2025-06-22 16:40 ` [PATCH v2 4/4] rust: devres: implement register_release() Danilo Krummrich
2025-06-22 20:47 ` Benno Lossin
2025-06-22 21:12 ` Danilo Krummrich
2025-06-22 21:20 ` Benno Lossin
2025-06-22 21:24 ` Danilo Krummrich
2025-06-22 22:29 ` Benno Lossin
2025-06-23 12:01 ` Alice Ryhl
2025-06-23 12:51 ` Danilo Krummrich
2025-06-23 13:40 ` Benno Lossin
2025-06-23 13:49 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFlLjQFZ8gzh5Mz6@cassiopeiae \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=airlied@redhat.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=david.m.ertman@intel.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=ira.weiny@intel.com \
--cc=kwilczynski@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=simona.vetter@ffwll.ch \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).