From: Lukas Wunner <lukas@wunner.de>
To: Manivannan Sadhasivam <mani@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Jim Quinlan <james.quinlan@broadcom.com>
Subject: Re: [PATCH v2] PCI/pwrctrl: Skip creating pwrctrl device unless CONFIG_PCI_PWRCTRL is enabled
Date: Tue, 1 Jul 2025 14:49:41 +0200 [thread overview]
Message-ID: <aGPZZcb9D4qKr2rM@wunner.de> (raw)
In-Reply-To: <n23tedrmgzfo7bxe4mbde2rrsayalcz4jya5yopoeahlll3qaw@mpz4oemtyern>
On Tue, Jul 01, 2025 at 05:27:27PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Jul 01, 2025 at 09:00:34AM GMT, Lukas Wunner wrote:
> > Hm, why does pci_pwrctrl_create_device() return a pointer, even though the
> > sole caller doesn't make any use of it? Why not return a negative errno?
> >
> > Then you could just do this:
> >
> > if (!IS_ENABLED(CONFIG_PCI_PWRCTRL))
> > return 0;
> >
> > ... at the top of the function and you don't need the extra LoC for the
> > empty inline stub.
>
> This is what I initially submitted [1] though that returned NULL, but the
> idea was the same. But Bjorn didn't like that.
[...]
Thanks for summarizing the state of the discussion, I apologize for not
having paid sufficient attention to the thread.
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Lukas
next prev parent reply other threads:[~2025-07-01 12:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 6:47 [PATCH v2] PCI/pwrctrl: Skip creating pwrctrl device unless CONFIG_PCI_PWRCTRL is enabled Manivannan Sadhasivam
2025-07-01 7:00 ` Lukas Wunner
2025-07-01 11:57 ` Manivannan Sadhasivam
2025-07-01 12:49 ` Lukas Wunner [this message]
2025-07-01 20:35 ` Bjorn Helgaas
2025-07-02 6:47 ` Manivannan Sadhasivam
2025-07-02 17:53 ` Bjorn Helgaas
2025-07-02 18:30 ` Manivannan Sadhasivam
2025-07-02 20:04 ` Bjorn Helgaas
2025-07-01 21:01 ` Bjorn Helgaas
2025-07-02 7:20 ` Manivannan Sadhasivam
2025-07-22 18:58 ` Bjorn Helgaas
2025-07-22 19:15 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aGPZZcb9D4qKr2rM@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox