From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 231162405F9; Tue, 15 Jul 2025 08:16:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.95.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752567392; cv=none; b=USyVDv+a6c1ywE1kIRGCPt62IeELUQ2x15sBtEvJf8cNHR000tUgqDTSFmHg6iUnsoCX2jJBuroNaCPAVI9zMnGtChEEnJOH0I16o8041v+LvY7uIfvCv8GZVj9EB8NbtOuoSB9JR/bsK9lzwvYGmwZJ9RDjF/JJ4wZHxoLQ898= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752567392; c=relaxed/simple; bh=49FlX1avA+FOW1F2dbzHOqWjJIKmKe/jaMgbW4rSOXM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EFpBwnCjkD8V4XY2g646O1XoFG3vlP2syhx4ls3fX/X6K4q//Mkd2TndOXqCzVK/xl+7BwHXKX4bOCLiYlH5neFdgir9R0uVFktBTI3TtdnVMIuUBZG6rDX0QJcd/utbPtzXgKHtxrbU99ntGZRDhHmHOwt/CwV8zGZEcWHA8lE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.95.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 5578C2C06843; Tue, 15 Jul 2025 10:16:27 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 20CD4390420; Tue, 15 Jul 2025 10:16:27 +0200 (CEST) Date: Tue, 15 Jul 2025 10:16:27 +0200 From: Lukas Wunner To: Manivannan Sadhasivam Cc: Bjorn Helgaas , Mahesh J Salgaonkar , Oliver O'Halloran , Will Deacon , Lorenzo Pieralisi , Krzysztof Wilczy??ski , Manivannan Sadhasivam , Rob Herring , Heiko Stuebner , Philipp Zabel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, Niklas Cassel , Wilfred Mallawa , Krishna Chaitanya Chundru Subject: Re: [PATCH v5 1/4] PCI/ERR: Add support for resetting the Root Ports in a platform specific way Message-ID: References: <20250715-pci-port-reset-v5-0-26a5d278db40@oss.qualcomm.com> <20250715-pci-port-reset-v5-1-26a5d278db40@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250715-pci-port-reset-v5-1-26a5d278db40@oss.qualcomm.com> On Tue, Jul 15, 2025 at 01:29:18PM +0530, Manivannan Sadhasivam wrote: > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -4964,7 +4964,19 @@ void pci_reset_secondary_bus(struct pci_dev *dev) > > void __weak pcibios_reset_secondary_bus(struct pci_dev *dev) > { > + struct pci_host_bridge *host = pci_find_host_bridge(dev->bus); > + int ret; > + > + if (host->reset_root_port) { > + ret = host->reset_root_port(host, dev); > + if (ret) > + pci_err(dev, "Failed to reset Root Port: %d\n", ret); > + > + return; > + } > + There used to be a pci_is_root_bus() check here: https://lore.kernel.org/r/20250524185304.26698-2-manivannan.sadhasivam@linaro.org/ Thanks, Lukas