Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Lukas Wunner <lukas@wunner.de>, Hongbo Yao <andy.xu@hj-micro.com>,
	Sathyanarayanan Kuppuswamy
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	bhelgaas@google.com, mahesh@linux.ibm.com, oohall@gmail.com,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	jemma.zhang@hj-micro.com, peter.du@hj-micro.com
Subject: Re: [PATCH] PCI/DPC: Extend DPC recovery timeout
Date: Wed, 6 Aug 2025 15:52:27 -0600	[thread overview]
Message-ID: <aJPOmw2c8LGW2qN7@kbusch-mbp> (raw)
In-Reply-To: <20250806213409.GA19037@bhelgaas>

On Wed, Aug 06, 2025 at 04:34:09PM -0500, Bjorn Helgaas wrote:
> > > However, the current 4 seconds timeout in pci_dpc_recovered() is indeed
> > > an empirical value rather than a hard requirement from the PCIe
> > > specification. In real-world scenarios, like with Mellanox ConnectX-5/7
> > > adapters, we've observed that full DPC recovery can take more than 5-6
> > > seconds, which leads to premature hotplug processing and device removal.
> > 
> > I think Sathya's point was:  Have you made an effort to talk to the
> > vendor and ask them to root-cause and fix the issue e.g. with a firmware
> > update.
> 
> Would definitely be great, but unless we have a number in the spec to
> point to, they might just shrug and ask what the requirement is.

I agree, and I have similar problems with other arbitrary kernel timing
decicsions. Specifically RRL where there's no spec defined number yet my
patch to modify it has not received much consideration.

  https://lore.kernel.org/linux-pci/20250218165444.2406119-1-kbusch@meta.com/

  reply	other threads:[~2025-08-06 21:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 10:30 [PATCH] PCI/DPC: Extend DPC recovery timeout Andy Xu
2025-07-07 17:04 ` Sathyanarayanan Kuppuswamy
2025-07-11  3:20   ` Hongbo Yao
2025-07-11  4:13     ` Lukas Wunner
2025-08-06 21:34       ` Bjorn Helgaas
2025-08-06 21:52         ` Keith Busch [this message]
2025-08-07  1:54           ` Ethan Zhao
2025-08-07  2:00     ` Ethan Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aJPOmw2c8LGW2qN7@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=andy.xu@hj-micro.com \
    --cc=bhelgaas@google.com \
    --cc=helgaas@kernel.org \
    --cc=jemma.zhang@hj-micro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mahesh@linux.ibm.com \
    --cc=oohall@gmail.com \
    --cc=peter.du@hj-micro.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox