From: Keith Busch <kbusch@kernel.org>
To: Nam Cao <namcao@linutronix.de>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
"Nirmal Patel" <nirmal.patel@linux.intel.com>,
"Jonathan Derrick" <jonathan.derrick@linux.dev>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczy´nski" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
"Ammar Faizi" <ammarfaizi2@gnuweeb.org>
Subject: Re: [PATCH] PCI: vmd: Remove MSI-X check on child devices
Date: Tue, 12 Aug 2025 13:41:10 -0600 [thread overview]
Message-ID: <aJuY1o4JAftObQhv@kbusch-mbp> (raw)
In-Reply-To: <20250812193219.9E_pRwle@linutronix.de>
On Tue, Aug 12, 2025 at 09:32:19PM +0200, Nam Cao wrote:
> On Tue, Aug 12, 2025 at 02:00:36PM -0500, Bjorn Helgaas wrote:
> > On Tue, Aug 12, 2025 at 08:22:09PM +0200, Nam Cao wrote:
> > > Minor correction, it is not just an unnecessary WARN_ON, but child devices'
> > > drivers couldn't enable MSI at all.
> > >
> > > So perhaps something like "Remove the sanity check to allow child devices
> > > which only support MSI".
> >
> > Thanks, updated.
>
> Sorry for the extra work I have been putting on you this cycle. I trust you
> understand it is for good reason.
>
> It is unfortunate that I do not have hardware for most patches I sent. The
> best I could do was staring at the patches until I think "yeah, that
> probably isn't broken". That obviously isn't good enough to remove all
> bugs. I wish that I could do better, but oh well...
>
> Thanks Ammar as well, for helping me tracking down this bug.
>
> I hope this one is the last regression report that we will see.
I'm sure intel can get you a proper hardware spec. Referencing marketing
white paper material to guide software changes is not a good idea. :)
next prev parent reply other threads:[~2025-08-12 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 5:39 [PATCH] PCI: vmd: Remove MSI-X check on child devices Nam Cao
2025-08-11 5:53 ` Ammar Faizi
2025-08-11 22:46 ` Bjorn Helgaas
2025-08-12 6:27 ` Nam Cao
2025-08-12 14:49 ` Keith Busch
2025-08-12 16:30 ` Bjorn Helgaas
2025-08-12 18:22 ` Nam Cao
2025-08-12 19:00 ` Bjorn Helgaas
2025-08-12 19:32 ` Nam Cao
2025-08-12 19:41 ` Keith Busch [this message]
2025-08-12 19:59 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aJuY1o4JAftObQhv@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=ammarfaizi2@gnuweeb.org \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jonathan.derrick@linux.dev \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=namcao@linutronix.de \
--cc=nirmal.patel@linux.intel.com \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox