From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60535279DA6 for ; Sat, 18 Oct 2025 09:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760780899; cv=none; b=XCl9OpEstljV6FTnvxmfaSj5CXMoh2wksd1yK32tA+qPJmpRuXIeA6TJ4cR5JVowVT8A7bzFEXixJVdv4JE67VAcLRcl9ir/tEEFQcZLf+X2XnCOXwYkvneSTnrbZQYTX1RANAsy/rf71CjmfjY0x0KPf9IMQMlE6jAoXxm7Gvo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760780899; c=relaxed/simple; bh=A7f0rcwMMhuOxtJjZ+3BE68ZThRKtbmxH6yOW94VjA4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XAR0W7snnFC2jFqkSVlw/3iIhyur2vRfyVs6TNkBas0W1658OFBs29SFuI1Wd5XymV+cVT1YyWU4xQaG14FClgVvTjVPZ3IT8bI5m7emVsTd5a8vBI0MEIErZXeqGdnIRcJMcIdEW4BVf9AQ2YDrd5ZUriX4B6qrUMzTVMYN9fc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=XdJXgugo; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XdJXgugo" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-47118259fd8so11943295e9.3 for ; Sat, 18 Oct 2025 02:48:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760780896; x=1761385696; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nhWVuNwxLp4oDhy9Y7Je0Sd3r/8yjdmEN4SRPPZ/YRc=; b=XdJXgugoJiC3tqkUxYfdqivCVFYy6DumHxlnfX8Ks8xVTD+WY3bGL7AO9PFHGiaIcT ugesKfl6+T5DM3XVJQzm9zLE2nqRSe8yMuywko7g0KYido+KrONE+eUzlrh7xHtb62J3 oA/vR5vMF+2feTtisKB/ohVL1XY79P7a4B5OimvGYOvOxznq2rQ9lJs46JXQWpsyau5/ Ke82gl/+quuB9qW89g87ibHB+ZUtx1KdE3TLF/E+aP7m5Z561+rYalrOCg1yddPuMw45 OuTrOnBclkjsC7SiUmWtGWKWeqfSEpfHnjUqRmICW/LgtJQtA1lvTM9r5dc7RPzOQABY fcTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760780896; x=1761385696; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nhWVuNwxLp4oDhy9Y7Je0Sd3r/8yjdmEN4SRPPZ/YRc=; b=Ll7ijNQWEJ+LT0QO1s5McDH8teVBbC/ioUhWKO/J5Bf7lMkChiYmxThUniOOh1S0b5 ktvH43R2okLjmKd4iJGnVWdf7pPW5Ju+aQnzc7GnVmr1T+eefialwHYe229OSWVQIoP+ amhbQ+M1QFdm2OhSfRY+vJpcEoXZQY11fQed1gRtoSE9Ihheq8YJA+ntU7lwSabZrivD U6pITol7/x9rsWm2HZzuy9bTj4IE/QHrynGCR23mUUnaIlZJ0oLT3tPivOujCAM118E+ G7EaU//yg3Ge8y3v+i6H0T+VNvDChLeXoMikVnEgkCRXRJY0fmILjj5IwP7ReLZ+CvMQ 2wiQ== X-Forwarded-Encrypted: i=1; AJvYcCVUd9LUEEdzrKBFCT7O2lcYZJQNGFo3P/VLKz9C5cQswV/f2+MVMS5tYFHPte100qjYsDognvJ0EQU=@vger.kernel.org X-Gm-Message-State: AOJu0YyiswcOeX2HRZZPvT2QISWmfJJ41jeF6rsaviUXPw+tFPzi3fw3 BaFLv2xg7dRNIsAfAc7mutcDtEpfE8rZwPd0gW4j5NIENjNKga91Z2RqyigrIWBOCiI= X-Gm-Gg: ASbGncsIgO7/EH/Qx6Q41IF9ntQ9n9V2wm4gdXBY4m2jzEm8yHGdvEdpnNQFr6+DPGm AZ51oRvbS4qI0XYxH7s0f2toLTO75ptIlaJ2WChyYjep02TNA34juun36YMFbU+lV2bPW14wp3R gTMVBg+K3fWVuLLGSKDEeMOfjjb2Lf1AfbS0ZYzELKtE13achPedP+UTzpLB8/iWCgINdXU62MU HVHymhTrXJ/0Y9DhpKpd0hor5h2C8x8yBG07cou7b9FjDjyf9OiJ+6919EkrGd/hIFdBqkyGABL EA79t6Q3WToTardNFQ4GhDUUTErU4RJuQ3hD/ovFI2LXFkPqkPxhG3g2npwkPauVCSK8Wu6VdKr Bm9+PdYuKbchOs9gGGl+POt0E8Dc1ieBrVCiple+tzXMAi4YYp4eEX9AS6Jpqh44/ncveAms7rO XP875WyEB0SVAEi1GD X-Google-Smtp-Source: AGHT+IG+kX1i7eggIHxYAK08ThcqnvRyiNfTqtAevzOHW/nGlWwTN/Eu/9VszT8osDHnwWAvHzqdHA== X-Received: by 2002:a05:600c:3e8f:b0:46f:a95d:e9e7 with SMTP id 5b1f17b1804b1-471177ab11dmr52244015e9.0.1760780895638; Sat, 18 Oct 2025 02:48:15 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4715257d916sm37111235e9.4.2025.10.18.02.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Oct 2025 02:48:15 -0700 (PDT) Date: Sat, 18 Oct 2025 12:48:11 +0300 From: Dan Carpenter To: Anand Moon Cc: Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , "open list:PCI DRIVER FOR TI DRA7XX/J721E" , "open list:PCI DRIVER FOR TI DRA7XX/J721E" , "moderated list:PCI DRIVER FOR TI DRA7XX/J721E" , open list Subject: Re: [PATCH v1 1/3] PCI: j721e: Propagate dev_err_probe return value Message-ID: References: <20251014113234.44418-1-linux.amoon@gmail.com> <20251014113234.44418-2-linux.amoon@gmail.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251014113234.44418-2-linux.amoon@gmail.com> On Tue, Oct 14, 2025 at 05:02:27PM +0530, Anand Moon wrote: > Ensure that the return value from dev_err_probe() is consistently assigned > back to ret in all error paths within j721e_pcie_probe(). This ensures > the original error code are propagation for debugging. > > Cc: Siddharth Vadapalli > Signed-off-by: Anand Moon > --- > v1: new patch in this series > --- > drivers/pci/controller/cadence/pci-j721e.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/pci/controller/cadence/pci-j721e.c b/drivers/pci/controller/cadence/pci-j721e.c > index 5bc5ab20aa6d..9c7bfa77a66e 100644 > --- a/drivers/pci/controller/cadence/pci-j721e.c > +++ b/drivers/pci/controller/cadence/pci-j721e.c > @@ -569,20 +569,20 @@ static int j721e_pcie_probe(struct platform_device *pdev) > pm_runtime_enable(dev); > ret = pm_runtime_get_sync(dev); > if (ret < 0) { > - dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n"); > + ret = dev_err_probe(dev, ret, "pm_runtime_get_sync failed\n"); > goto err_get_sync; Wait, no, this doesn't make sense. It's just assigning ret to itself. That's just confusing and pointless. regards, dan carpenter