From: Brian Norris <briannorris@chromium.org>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI/PM: Ensure power-up succeeded before restoring MMIO state
Date: Thu, 23 Oct 2025 09:34:42 -0700 [thread overview]
Message-ID: <aPpZIovpDU2KU_gg@google.com> (raw)
In-Reply-To: <20250821075812.1.I2dbf483156c328bc4a89085816b453e436c06eb5@changeid>
On Thu, Aug 21, 2025 at 07:58:12AM -0700, Brian Norris wrote:
> From: Brian Norris <briannorris@google.com>
>
> As the comments in pci_pm_thaw_noirq() suggest, pci_restore_state() may
> need to restore MSI-X state in MMIO space. This is only possible if we
> reach D0; if we failed to power up, this might produce a fatal error
> when touching memory space.
>
> Check for errors (as the "verify" in "pci_pm_power_up_and_verify_state"
> implies), and skip restoring if it fails.
>
> This mitigates errors seen during resume_noirq, for example, when the
> platform did not resume the link properly.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Brian Norris <briannorris@google.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Friendly ping on this one.
This bug causes quite a bit of problem for some Pixel devices, although
that's admittedly because of our own failure to resume properly in some
cases. (And we can recover later, if we don't crash here.)
I believe the patch is still a good addition for everyone, in case other
systems fall into similar error conditions.
Brian
next prev parent reply other threads:[~2025-10-23 16:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 14:58 [PATCH] PCI/PM: Ensure power-up succeeded before restoring MMIO state Brian Norris
2025-10-23 16:34 ` Brian Norris [this message]
2025-10-23 17:25 ` Bjorn Helgaas
2025-10-23 18:01 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPpZIovpDU2KU_gg@google.com \
--to=briannorris@chromium.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).