From: Lukas Wunner <lukas@wunner.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Cc: bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs
Date: Thu, 20 Nov 2025 17:04:31 +0100 [thread overview]
Message-ID: <aR88DxZST5r9Va2S@wunner.de> (raw)
In-Reply-To: <20251120154601.116806-1-mani@kernel.org>
On Thu, Nov 20, 2025 at 09:16:01PM +0530, Manivannan Sadhasivam wrote:
> +++ b/drivers/pci/quirks.c
> @@ -2525,6 +2525,18 @@ static void quirk_disable_aspm_l0s_l1(struct pci_dev *dev)
> */
> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x1080, quirk_disable_aspm_l0s_l1);
>
> +static void quirk_disable_aspm_l1(struct pci_dev *dev)
> +{
> + pci_info(dev, "Disabling ASPM L1\n");
> + pci_disable_link_state(dev, PCIE_LINK_STATE_L1);
> +}
Shouldn't this be using pcie_aspm_remove_cap()? Existing quirks
were converted to this new helper with 30579eebba6a.
Thanks,
Lukas
next prev parent reply other threads:[~2025-11-20 16:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 15:46 [PATCH] PCI: Add quirk to disable ASPM L1 for Sandisk SN740 NVMe SSDs Manivannan Sadhasivam
2025-11-20 15:50 ` Konrad Dybcio
2025-11-20 16:04 ` Manivannan Sadhasivam
2025-11-20 16:04 ` Lukas Wunner [this message]
2025-11-20 16:07 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aR88DxZST5r9Va2S@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=manivannan.sadhasivam@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox