From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Guixin Liu <kanie@linux.alibaba.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v10 1/2] PCI: Introduce named defines for pci rom
Date: Fri, 12 Dec 2025 17:02:02 +0200 [thread overview]
Message-ID: <aTwuatZYJEerx1cL@smile.fi.intel.com> (raw)
In-Reply-To: <20251212093711.36407-2-kanie@linux.alibaba.com>
On Fri, Dec 12, 2025 at 05:37:09PM +0800, Guixin Liu wrote:
> Convert the magic numbers associated with PCI ROM into named
> definitions. Some of these definitions will be used in the second
> fix patch.
Now this LGTM, thanks!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-12-12 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 9:37 [PATCH v10 0/2] PCI: Fix crash when access broken rom Guixin Liu
2025-12-12 9:37 ` [PATCH v10 1/2] PCI: Introduce named defines for pci rom Guixin Liu
2025-12-12 15:02 ` Andy Shevchenko [this message]
2025-12-12 15:17 ` Ilpo Järvinen
2025-12-12 18:13 ` Bjorn Helgaas
2025-12-15 2:06 ` Guixin Liu
2025-12-12 9:37 ` [PATCH v10 2/2] PCI: Check rom header and data structure addr before accessing Guixin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTwuatZYJEerx1cL@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bhelgaas@google.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kanie@linux.alibaba.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox