From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 713DB39E6F9 for ; Wed, 14 Jan 2026 15:44:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768405440; cv=none; b=j+AxAzDNCQTXoD/AEnOk6xNdF9CfENSH+KHCdxm+6X+sx3/aCN34YitO70Wxp95xl6GX7cDGXe1qpbYrF2uQHH460MQYY6pwFUD6Wgw5ZPbFbjriUHwuREfj+yabjxDAgVdzxx7Vonu9pC/v2Fzzv0i1hHACtDZzx8jFoL1cTAk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768405440; c=relaxed/simple; bh=ReVz6cPlRsm4lE4yj8qgNYX22f2C5+7rwEPvVzG9M+Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XybR1Cwu7OwYvakc6jqqVFrEgQxNWG2EJpGsFKucMm9mdWHiNNAoyaq4Y5UDiV3Q1vg0XXQWxpxH3rsK21WApISRx2tWexzTKE7P9Q1cnLOM0UpwlS57klM70Y6fBa6SXsiHDrro+3fipAWMetUy8D953WO4SwFNG4+4Mkp2Re0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t6H+7e2d; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t6H+7e2d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3155BC16AAE; Wed, 14 Jan 2026 15:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768405440; bh=ReVz6cPlRsm4lE4yj8qgNYX22f2C5+7rwEPvVzG9M+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=t6H+7e2dbK9gQEvEZJKxd76IWSbrl5frhABmypwBkBSe9/hSV1JA+4/TRUsjzkl5w XQEZ1EISjXhn47N72nETB4OFNxb7Lsio8Sz0v77iL/NIBXmw4NRPzMMKcBkmee+gzp UuJZakX/7QiK0Jto7I52nmYYQUgT7XroBKqdcNCmSVRUM56w1rTDGIm3d9tNZ/wdan Ds5w84/WQgFGuxoEYkU0ORjWDlKOBID7SYhI6+PAvnT0xOG+wxCIOtA9r7h0AnNA8+ PkMGMTv8WY0Tgb7nY7IsVGFeDpSht3jygHKnLmdBhkyM5alXbV4JdzK270X3LyXATw vM8Uz3eOiZcVA== Date: Wed, 14 Jan 2026 16:43:53 +0100 From: Niklas Cassel To: Shawn Lin Cc: Manivannan Sadhasivam , Bjorn Helgaas , Vinod Koul , linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, Heiko Stuebner , Neil Armstrong , Sebastian Reichel Subject: Re: [PATCH 0/5] Add calibration for Synopsys PCIe PHY and Controller Message-ID: References: <1766560210-100883-1-git-send-email-shawn.lin@rock-chips.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1766560210-100883-1-git-send-email-shawn.lin@rock-chips.com> On Wed, Dec 24, 2025 at 03:10:05PM +0800, Shawn Lin wrote: > > Currently, when pcie-dw-rockchip uses the Synopsys PHY, it relies on > the phy_init() callback of the phy-rockchip-snps-pcie3 driver to > perform calibration. This is incorrect because the controller is > still held in reset at that time, preventing the PHY from accurately > reflecting the actual PLL lock and calibration status. Hello Shawn, I can see that you move the calibration code from .phy_init() to .phy_calibrate(). And I understandthat the controller is still held in reset. I understand that the the PHY calibration is supposed to be done when the controller is not held in reset, and that alone is enough to warrant a fix. The Synopsys Gen3 PHY is used in e.g. Rock5b, and link training currently works fine with this PHY, so what is the actual implications of performing the PHY calibration when the controller is held in reset? Will it somehow it improve signal integrity? Kind regards, Niklas > > To fix this, this series: > 1. Calls phy_calibrate() in the pcie-dw-rockchip driver (if supported) > after the controller is out of reset, ensuring the PHY can > properly synchronize with the controller state. > 2. Adds the necessary calibration support in the Synopsys PHY driver > to implement this callback.