From: Keith Busch <kbusch@kernel.org>
To: Leon Romanovsky <leon@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
Qinyun Tan <qinyuntan@linux.alibaba.com>,
Jens Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org,
Xunlei Pang <xlpang@linux.alibaba.com>,
Guixin Liu <kanie@linux.alibaba.com>,
oliver.yang@linux.alibaba.com,
Guanghui Feng <guanghuifeng@linux.alibaba.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH V1] nvme-pci: disable SR-IOV VFs on driver unbind
Date: Tue, 27 Jan 2026 09:06:55 -0700 [thread overview]
Message-ID: <aXjin6e18UxcTpQz@kbusch-mbp> (raw)
In-Reply-To: <20260127143143.GW13967@unreal>
On Tue, Jan 27, 2026 at 04:31:43PM +0200, Leon Romanovsky wrote:
> On Tue, Jan 27, 2026 at 09:48:07AM +0100, Christoph Hellwig wrote:
> > On Tue, Jan 27, 2026 at 03:33:44PM +0800, Qinyun Tan wrote:
> > > The NVMe PCI driver exports the sriov_configure callback via
> > > pci_sriov_configure_simple(), which allows userspace to enable SR-IOV
> > > VFs through sysfs. However, when the PF driver is unbound, the driver
> > > does not disable SR-IOV, leaving VFs orphaned in the system.
> >
> > That sounds dangerous.
>
> It is not. In a real SR-IOV device, VFs are created by the hardware and
> are independent of their PF. There are several use cases where an
> operator unbinds the PF and reuses it to improve overall device
> utilization.
If this is expected, should the warn message "driver left SR-IOV enabled
after remove" be downgraded to 'info' level?
next prev parent reply other threads:[~2026-01-27 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260127073344.2489873-1-qinyuntan@linux.alibaba.com>
2026-01-27 8:48 ` [PATCH V1] nvme-pci: disable SR-IOV VFs on driver unbind Christoph Hellwig
2026-01-27 14:31 ` Leon Romanovsky
2026-01-27 16:06 ` Keith Busch [this message]
2026-01-27 18:00 ` Leon Romanovsky
2026-01-27 23:09 ` Bjorn Helgaas
2026-01-27 23:43 ` Jakub Kicinski
2026-01-28 8:44 ` Leon Romanovsky
2026-01-30 4:53 ` qinyuntan
2026-02-06 22:28 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXjin6e18UxcTpQz@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=guanghuifeng@linux.alibaba.com \
--cc=hch@lst.de \
--cc=kanie@linux.alibaba.com \
--cc=leon@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=oliver.yang@linux.alibaba.com \
--cc=qinyuntan@linux.alibaba.com \
--cc=sagi@grimberg.me \
--cc=xlpang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox