public inbox for linux-pci@vger.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Keith Busch <kbusch@meta.com>,
	linux-pci@vger.kernel.org, bhelgaas@google.com, alex@shazbot.org,
	lukas@wunner.de, Dan Williams <dan.j.williams@intel.com>,
	Jinhui Guo <guojinhui.liam@bytedance.com>
Subject: Re: [PATCH 2/2] pci: fix slot reset device locking
Date: Thu, 29 Jan 2026 08:59:38 -0700	[thread overview]
Message-ID: <aXuD6uYNIeYVJVL5@kbusch-mbp> (raw)
In-Reply-To: <20260128225359.GA437372@bhelgaas>

On Wed, Jan 28, 2026 at 04:53:59PM -0600, Bjorn Helgaas wrote:
> 
> I have no idea why the pci_slot_lock() hunk got applied in
> pci_slot_restore_locked().  I do notice that the line offsets in your
> patch are much different than mine, so you must have other changes in
> pci.c; maybe that accounts for the confusion.

Oh weird. I'd hope that patch just wouldn't have applied in that case
instead of appearing successful.

I was using a newer branch that also included some other fixes I'm
working on, so not surprised the line numbers didn't match up. I'll
rebase future patches to v6.19-rc1.
 
> Can you regenerate this patch based on v6.19-rc1?  And maybe
> incorporate Dan's "bridge = slot->bus->self" idea at the same time?

I've got a new proposal about ready that just drops the slot specific
lock/unlock and save/restore instead. We kind of need to do that since
slot reset breaks devices with more than 8 functions. I'll send the
patch with the details in a few minutes.

  reply	other threads:[~2026-01-29 15:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-16 18:41 [PATCH 1/2] pci: fix slot trylock error handling Keith Busch
2026-01-16 18:41 ` [PATCH 2/2] pci: fix slot reset device locking Keith Busch
2026-01-28 18:03   ` Bjorn Helgaas
2026-01-28 19:13     ` Keith Busch
2026-01-28 22:53       ` Bjorn Helgaas
2026-01-29 15:59         ` Keith Busch [this message]
2026-01-28 19:54     ` Ilpo Järvinen
2026-01-28 21:07       ` dan.j.williams
2026-01-28 21:11         ` Bjorn Helgaas
2026-01-28 21:00   ` dan.j.williams
2026-01-27 16:09 ` [PATCH 1/2] pci: fix slot trylock error handling Keith Busch
2026-01-28  9:16   ` Ilpo Järvinen
2026-01-28 15:11     ` Keith Busch
2026-01-28 15:14       ` Ilpo Järvinen
2026-01-27 23:20 ` Bjorn Helgaas
2026-01-28 20:47 ` dan.j.williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXuD6uYNIeYVJVL5@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=alex@shazbot.org \
    --cc=bhelgaas@google.com \
    --cc=dan.j.williams@intel.com \
    --cc=guojinhui.liam@bytedance.com \
    --cc=helgaas@kernel.org \
    --cc=kbusch@meta.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox