From: Keith Busch <kbusch@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Keith Busch <kbusch@meta.com>,
linux-pci@vger.kernel.org, alex@shazbot.org, lukas@wunner.de,
dan.j.williams@intel.com, guojinhui.liam@bytedance.com,
ilpo.jarvinen@linux.intel.com
Subject: Re: [PATCH] pci: remove slot specific lock/unlock and save/restore
Date: Thu, 29 Jan 2026 14:16:42 -0700 [thread overview]
Message-ID: <aXvOOjZQ_EmZDgVs@kbusch-mbp> (raw)
In-Reply-To: <20260129202750.GA476192@bhelgaas>
On Thu, Jan 29, 2026 at 02:27:50PM -0600, Bjorn Helgaas wrote:
> An alternate path would be to:
>
> - keep Jinhui's patch that fixes the pci_slot_trylock() error path
> (same as your 1/1 patch)
>
> - apply your 2/2 patch [1] to fix pci_slot_lock(),
> pci_slot_unlock(), and pci_slot_trylock() to lock the bridge
> (after accounting for the mistaken merge)
>
> - finally, rebase *this* patch on top to remove the pci_slot_lock(),
> pci_slot_unlock(), and pci_slot_trylock() that have just been
> fixed
>
> The advantage would be that if there's any issue or objection to
> completely removing pci_slot_lock() et al, we could drop or defer that
> while still fixing the locking issues.
Sounds good. Another bonus is we can be more cautious for stable
backports since the first two are clear isolated bug fixes. I'll prepare
a rebased version with the proposed sequence.
prev parent reply other threads:[~2026-01-29 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 16:09 [PATCH] pci: remove slot specific lock/unlock and save/restore Keith Busch
2026-01-29 20:27 ` Bjorn Helgaas
2026-01-29 21:16 ` Keith Busch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXvOOjZQ_EmZDgVs@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=alex@shazbot.org \
--cc=dan.j.williams@intel.com \
--cc=guojinhui.liam@bytedance.com \
--cc=helgaas@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kbusch@meta.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox