Re: [PATCH] pci: remove slot specific lock/unlock and save/restore

Keith Busch
2026-01-29T21:16:44Z

On Thu, Jan 29, 2026 at 02:27:50PM -0600, Bjorn Helgaas wrote:
> An alternate path would be to:
>
> - keep Jinhui's patch that fixes the pci_slot_trylock() error path
> (same as your 1/1 patch)
>
> - apply your 2/2 patch [1] to fix pci_slot_lock(),
> pci_slot_unlock(), and pci_slot_trylock() to lock the bridge
> (after accounting for the mistaken merge)
>
> - finally, rebase *this* patch on top to remove the pci_slot_lock(),
> pci_slot_unlock(), and pci_slot_trylock() that have just been
> fixed
>
> The advantage would be that if there's any issue or objection to
> completely removing pci_slot_lock() et al, we could drop or defer that
> while still fixing the locking issues.

Sounds good. Another bonus is we can be more cautious for stable
backports since the first two are clear isolated bug fixes. I'll prepare
a rebased version with the proposed sequence.