From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23DEE31328A for ; Fri, 6 Feb 2026 23:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770419693; cv=none; b=AofWGtjSu6RwQ2NedTTO0MIX22gfmXHJWa5ipfXOVGnQMRvZ+xJsQBKym+yxWX0o8BInbrOJed2w8VsUYgJ+1IhRAXmC3wr1dti8p/8t23paYT8T40cDS9CxpjCuwHFNVhBRflfwVb/X/2Xx6vzTYUSOkAZKt/sCIh8325slGKY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770419693; c=relaxed/simple; bh=//lXxvGzvwvRX8TAWjBtg2RwKbUnQc3RJsVA6A3Oyik=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bdehFWRwf4HpIebLyKJ4HnxkLX0iI3KQ+1dwMlvs6QfGGVc2psPjVFxATIjQ1P3rH9OgpWoe5Wc7ZrGh8puIHXEBOSQVZkOZVyfDBTlGm/TvsZeGWzSYJCPeLTBfXmzwTnOZ3ZXa6wYo3fnKvaYA3JC6r4ixu17N3dF3rnmsUMU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=g3tRWC1l; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="g3tRWC1l" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2a79ded11a2so18541445ad.3 for ; Fri, 06 Feb 2026 15:14:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1770419692; x=1771024492; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=xORO1Htmm6YxNYM1C9oAOOlxqgAaEPMiLYXG8QXy21k=; b=g3tRWC1lBp4G6v57OMNJH/IWhVnKhZkgx/YZiytE6h7F/GblmQyEeomg0JeF945imr 3DB0TWRGaESQe070W0BWOsUsHHgvWnyNF6EEwR5gbcMaxsCWtsRq1Fe05Wodqe+0qye2 LBmPBBEaSzUa/6BVN4mGd5ytwg0pv9jYELANMZypZY/N1Rk4NZK0jaWANUovaQTw19Op /8LEugHReBQZGwa4owCg//1Vcv3ViHo6xmE5eGqCTRiTfYejf8j7ME+YpxzTkLA9rqSr Q2sFeCKKNGRwrLl2prU/fOIUJF/CpaYN2BHv2qZMRrBdGsbsQA9CbV1GnPE3RBNl1TaN FKLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770419692; x=1771024492; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xORO1Htmm6YxNYM1C9oAOOlxqgAaEPMiLYXG8QXy21k=; b=AR7PxVrZXLyBOJAvT4/8nJLAsKZogPoxjZaE0sYEPIpY+pxo/bmsljgAtqcbwnvX0f CVl/DWh/a+Ww2JwvRAy4CMvggyQf1YQ/icYID+IVSMDMGDyGfkatlJJoOqOslUnKnDs1 Hu9Rq/kYXocLyyNnwEEJteViWCfuRd+2OAzJtgz7wq1EUvantAH0BGkIUvVNVRfMKa1R iqHuHhZFpJYl27VQ6HQBAB98MGy0LoIt5kCJsBdFla2O26Uw2rG9hm+X276e+jGhC3zi vLfYIW6AtLLNCBAUeGMHN8teO0vTSACPGoCyKbjajKg5YTKtFMaBXO34J3Yemiebi49v ISJQ== X-Forwarded-Encrypted: i=1; AJvYcCVvvfmRtNRLFOuqnEj8ZZVWY0kb66QWfbuAxGC0bNuhLhGmzA6U6LWBORdE+X8PDB/QABIO3zJ6m4c=@vger.kernel.org X-Gm-Message-State: AOJu0YzE8gRJVboWrcULaMfSqGrdSWGay02eOcfKPdjDfw3T0QxATn7D 9bX314RrA/qKg06PQ2jcuWambSuRxHTVKmUhhLMEOOR760DTUjoNpVMO0D/6OMclmw== X-Gm-Gg: AZuq6aJZ6xvqFDtwtUW1f2RkrdCuYEKOW8OMG8ufXEnQYb319YGIN8hRdESi+xil87w JyTVkOmigpsJrzeFJT/9ToJPbMi1cZK2igB1ttII3nyNJ3n2++F1fBrQ4o6t/OS+CAU4B7mxDPj rzgNvB7fpX6GmOQiA79dHgcqjVc32WRMWCXCgHXnbpsCnCWs4NNQk/MzQVhaATckO9pgxno3f/Z q+iAYQyXHSE1B1rLPmDmA+32ofNgzbAcn+li18EBIBE4rwTVm1WPsNAS43CN6w6XJORdvG4Mi+6 kdiZedVp0fOAfri3hq+rm6/vPuTUHueClfRs1UP4miyYhN3hRNWV2z+lOk52MWzKvFHcyh5t2r6 BFp17CFRS4LstgMqp5f73jHwIGtkjleFzTGIIaJHgJY0uxOVExaFkI3eIE/vb7PJaUNR2d/kVjt mPC5Z2fyepyVQxwK7Ocmg3pdkco9nDEUf+6VrQZnPOnxM80G2wNA== X-Received: by 2002:a17:903:3bcb:b0:2a0:c1ed:c8c2 with SMTP id d9443c01a7336-2a95191f76emr38694515ad.55.1770419692202; Fri, 06 Feb 2026 15:14:52 -0800 (PST) Received: from google.com (79.217.168.34.bc.googleusercontent.com. [34.168.217.79]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a9521eb87fsm33865195ad.71.2026.02.06.15.14.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 15:14:51 -0800 (PST) Date: Fri, 6 Feb 2026 23:14:46 +0000 From: David Matlack To: "Yanjun.Zhu" Cc: Alex Williamson , Adithya Jayachandran , Alexander Graf , Alex Mastro , Alistair Popple , Andrew Morton , Ankit Agrawal , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Kevin Tian , kexec@lists.infradead.org, kvm@vger.kernel.org, Leon Romanovsky , Leon Romanovsky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Lukas Wunner , =?utf-8?Q?Micha=C5=82?= Winiarski , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Raghavendra Rao Ananta , Rodrigo Vivi , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Tomita Moeko , Vipin Sharma , Vivek Kasireddy , William Tu , Yi Liu Subject: Re: [PATCH v2 04/22] vfio/pci: Register a file handler with Live Update Orchestrator Message-ID: References: <20260129212510.967611-1-dmatlack@google.com> <20260129212510.967611-5-dmatlack@google.com> <6dc423bd-36e6-4f97-b2b2-c7030575a3a1@linux.dev> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6dc423bd-36e6-4f97-b2b2-c7030575a3a1@linux.dev> On 2026-02-06 02:37 PM, Yanjun.Zhu wrote: > On 1/29/26 1:24 PM, David Matlack wrote: > > +int __init vfio_pci_liveupdate_init(void) > > +{ > > + if (!liveupdate_enabled()) > > + return 0; > 813 int liveupdate_register_file_handler(struct liveupdate_file_handler *fh) > 814 { > 815         struct liveupdate_file_handler *fh_iter; > 816         int err; > 817 > 818         if (!liveupdate_enabled()) > > 819                 return -EOPNOTSUPP; > > In the function liveupdate_register_file_handler, liveupdate_enabled is also checked. > as such, it is not necessary to check here? Yeah that is a bit odd. I see that memfd_luo_init() just checks for -EOPNOTSUPP. We can do the same thing here.