From: James Ettle <james@ettle.org.uk>
To: "Bjorn Helgaas" <helgaas@kernel.org>, "吳昊澄 Ricky" <ricky_wu@realtek.com>
Cc: Rui Feng <rui_feng@realsil.com.cn>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <lenb@kernel.org>,
Puranjay Mohan <puranjay12@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jacopo De Simoi <wilderkde@gmail.com>
Subject: Re: rtsx_pci not restoring ASPM state after suspend/resume
Date: Sat, 25 Jul 2020 21:27:11 +0100 [thread overview]
Message-ID: <aaa64572fac0fc411b79a9adb59b5bbcbdf4b1a8.camel@ettle.org.uk> (raw)
In-Reply-To: <20200724231309.GA1551055@bjorn-Precision-5520>
On Fri, 2020-07-24 at 18:13 -0500, Bjorn Helgaas wrote:
>
> Maybe we should simplify this a little bit more. James, if you don't
> touch ASPM config at all, either manually or via udev, does the ASPM
> configuration stay the same across suspend/resume?
>
Yes, it stays the same. Explicitly:
With the udev rule disabled, immediately following clean boot from
power-off (and no additional tinkering), ASPM is OFF to the best of my
knowledge:
- link/l1_aspm in sysfs is 0 for PCI devices 0000:01:00.[01];
- the processor sleeps no deeper than package C3.
The situation above is the same following a suspend/resume cycle --
both in terms of sysfs, and observed package C-state occupancy.
[Tested on kernel 5.7.10, but the behaviour is the same as prior
kernels.]
Thanks,
James.
next prev parent reply other threads:[~2020-07-25 20:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-23 16:56 rtsx_pci not restoring ASPM state after suspend/resume Bjorn Helgaas
2020-07-23 17:12 ` Bjorn Helgaas
2020-07-24 7:16 ` 吳昊澄 Ricky
2020-07-24 23:13 ` Bjorn Helgaas
2020-07-25 20:27 ` James Ettle [this message]
2020-07-27 14:14 ` Bjorn Helgaas
2020-07-27 19:52 ` James Ettle
2020-07-27 21:47 ` Bjorn Helgaas
2020-07-28 5:46 ` 吳昊澄 Ricky
2020-07-28 20:57 ` James Ettle
2020-07-28 23:06 ` Bjorn Helgaas
2020-08-02 16:30 ` James Ettle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa64572fac0fc411b79a9adb59b5bbcbdf4b1a8.camel@ettle.org.uk \
--to=james@ettle.org.uk \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=puranjay12@gmail.com \
--cc=ricky_wu@realtek.com \
--cc=rui_feng@realsil.com.cn \
--cc=wilderkde@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox